bpo-43950: ensure source_line is present when specializing the traceback by isidentical · Pull Request #27313 · python/cpython · GitHub

There seems to be different cases where the _PyDisplay_Line() function returns 0 without displaying the actual line but also without having any errors raised.

cpython/Python/traceback.c

Lines 414 to 420 in 4512848

    
           /* use the right encoding to decode the file as unicode */ 
        
           fd = PyObject_AsFileDescriptor(binary); 
        
           if (fd < 0) { 
        
               Py_DECREF(io); 
        
               Py_DECREF(binary); 
        
               return 0; 
        
           }

cpython/Python/traceback.c

Lines 436 to 446 in 4512848

    
           if (fob == NULL) { 
        
               PyErr_Clear(); 
        
               res = _PyObject_CallMethodIdNoArgs(binary, &PyId_close); 
        
               Py_DECREF(binary); 
        
               if (res) 
        
                   Py_DECREF(res); 
        
               else 
        
                   PyErr_Clear(); 
        
               return 0; 
        
           }

This patch ensures that the line is retrieved and displayed.

https://bugs.python.org/issue43950

Would it be better to fix _Py_DisplaySourceLine() instead?

I am not sure how would the fix look beside introducing a new return code for cases that did not result with printing the line but also without an error which seems more complicated.

…

On Fri, Jul 23, 2021, 10:45 PM Dennis Sweeney ***@***.***> wrote: Would it be better to fix _Py_DisplaySourceLine() instead? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#27313 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALJKHQPWWFKTA45LSTO5FS3TZHBGFANCNFSM5A4RI23Q> .

Can we add a regression test for this? (Like the one on the BPO issue?)

🤖 New build scheduled with the buildbot fleet by @isidentical for commit 8db4e0c 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

It seems like refleaks bots also fail on the main too, so that can be ignored.

bpo-43950: ensure source_line is present when specializing the traceback

ff5ecbe

bedevere-bot added the awaiting core review label Jul 23, 2021

the-knights-who-say-ni added the CLA signed label Jul 23, 2021

isidentical added the skip news label Jul 23, 2021

sweeneyde approved these changes Jul 23, 2021

View reviewed changes

isidentical added 2 commits July 23, 2021 23:18

add a regression test

24bab74

use a lower value

8db4e0c

isidentical added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 23, 2021

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 23, 2021

isidentical requested review from ammaraskar and pablogsal July 24, 2021 09:42

pablogsal approved these changes Jul 24, 2021

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting core review labels Jul 24, 2021

pablogsal merged commit c836231 into python:main Jul 24, 2021

bedevere-bot removed the awaiting merge label Jul 24, 2021

sthagen mentioned this pull request Jul 24, 2021

bpo-43950: ensure source_line is present when specialising the traceb… sthagen/python-cpython#561

Merged

pablogsal mentioned this pull request Apr 13, 2022

Include column offsets for bytecode instructions #88116

Closed

serhiy-storchaka mentioned this pull request Jun 9, 2026

gh-80384: Check that callback is callable at weak reference creation #151145

Merged

bpo-43950: ensure source_line is present when specializing the traceback by isidentical · Pull Request #27313 · python/cpython · GitHub

Uh oh!

Uh oh!

bpo-43950: ensure source_line is present when specializing the traceback - #27313

bpo-43950: ensure source_line is present when specializing the traceback#27313
pablogsal merged 3 commits into
python:mainfrom
colnotab:ensure-source-line-is-displayed

isidentical commented Jul 23, 2021 •
edited
Loading

Uh oh!

Uh oh!

sweeneyde commented Jul 23, 2021

Uh oh!

isidentical commented Jul 23, 2021 via email

Uh oh!

pablogsal commented Jul 23, 2021

Uh oh!

bedevere-bot commented Jul 23, 2021

Uh oh!

isidentical commented Jul 24, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

	/* use the right encoding to decode the file as unicode */
	fd = PyObject_AsFileDescriptor(binary);
	if (fd < 0) {
	Py_DECREF(io);
	Py_DECREF(binary);
	return 0;
	}

	if (fob == NULL) {
	PyErr_Clear();

	res = _PyObject_CallMethodIdNoArgs(binary, &PyId_close);
	Py_DECREF(binary);
	if (res)
	Py_DECREF(res);
	else
	PyErr_Clear();
	return 0;
	}

bpo-43950: ensure source_line is present when specializing the traceback by isidentical · Pull Request #27313 · python/cpython · GitHub

Uh oh!

Uh oh!

bpo-43950: ensure source_line is present when specializing the traceback - #27313

bpo-43950: ensure source_line is present when specializing the traceback#27313pablogsal merged 3 commits intopython:mainpython/cpython:mainfrom colnotab:ensure-source-line-is-displayedcolnotab/cpython:ensure-source-line-is-displayedCopy head branch name to clipboard

Conversation

isidentical commented Jul 23, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sweeneyde commented Jul 23, 2021

Uh oh!

isidentical commented Jul 23, 2021 via email

Uh oh!

pablogsal commented Jul 23, 2021

Uh oh!

bedevere-bot commented Jul 23, 2021

Uh oh!

isidentical commented Jul 24, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

bpo-43950: ensure source_line is present when specializing the traceback#27313
pablogsal merged 3 commits into
python:mainfrom
colnotab:ensure-source-line-is-displayed

isidentical commented Jul 23, 2021 •
edited
Loading