FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-44676: Fix reference leaks in union_reduce by pablogsal · Pull Request #27332 · python/cpython · GitHub

/ cpython Public

bpo-44676: Fix reference leaks in union_reduce - #27332

Merged
miss-islington merged 1 commit into
python:mainfrom
pablogsal:bpo-44676
Jul 24, 2021
ConversationCommits (1)ChecksFiles changed
Merged

bpo-44676: Fix reference leaks in union_reduce#27332
miss-islington merged 1 commit into
python:mainfrom
pablogsal:bpo-44676

Conversation

pablogsal commented Jul 24, 2021 •
edited by miss-islington
Loading

Copy link
Copy Markdown
Member

https://bugs.python.org/issue44676

Automerge-Triggered-By: GH:pablogsal

pablogsal mentioned this pull request Jul 24, 2021
Merged
pablogsal requested a review from Fidget-Spinner July 24, 2021 13:26
Fidget-Spinner approved these changes Jul 24, 2021
View reviewed changes

Fidget-Spinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This is a neat fix :). Didn't know about the N format string.

Fidget-Spinner added needs backport to 3.10 only security fixes and removed needs backport to 3.10 only security fixes labels Jul 24, 2021

Fidget-Spinner commented Jul 24, 2021

Copy link
Copy Markdown
Member

Woops I just realized we didn't backport GH-27244. So we don't need to backport this. Thanks the quick fix Pablo!

pablogsal mentioned this pull request Jul 24, 2021
Merged

pablogsal commented Jul 24, 2021

Copy link
Copy Markdown
Member Author

I am backporting GH-27244 with this fix in #27333

corona10 approved these changes Jul 24, 2021
View reviewed changes

corona10 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality 
0:00:00 load avg: 3.08 Run tests sequentially
0:00:00 load avg: 3.08 [1/1] test_types
beginning 6 repetitions
123456
......

== Tests result: SUCCESS ==

1 test OK.

Total duration: 1.1 sec
Tests result: SUCCESS

I also checked that this PR fix the leak issue :)

miss-islington commented Jul 24, 2021

Copy link
Copy Markdown
Contributor

@pablogsal: Status check is done, and it's a success ✅ .

miss-islington merged commit 8158e05 into python:main Jul 24, 2021
pablogsal deleted the bpo-44676 branch July 24, 2021 15:22

pablogsal commented Jul 24, 2021

Copy link
Copy Markdown
Member Author

Thanks for the review @corona10 and @Fidget-Spinner !

sthagen added a commit to sthagen/python-cpython that referenced this pull request Jul 24, 2021
Merge pull request #563 from python/main
53fd5ab 
bpo-44676: Fix reference leaks in union_reduce (pythonGH-27332)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

corona10 corona10 approved these changes
Fidget-Spinner Fidget-Spinner approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL