FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-25008: Deprecate smtpd and point to aiosmtpd by warsaw · Pull Request #274 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

bpo-25008: Deprecate smtpd and point to aiosmtpd - #274

Merged
vstinner merged 2 commits into
python:masterfrom
warsaw:bpo-25008
Feb 24, 2017
ConversationCommits (2)ChecksFiles changed
Merged

bpo-25008: Deprecate smtpd and point to aiosmtpd#274
vstinner merged 2 commits into
python:masterfrom
warsaw:bpo-25008

Conversation

warsaw commented Feb 24, 2017

Copy link
Copy Markdown
Member

We should probably also cherry pick this change into 3.4, 3.5, and 3.6 since those are the versions aiosmtpd are compatible with.

vstinner reviewed Feb 24, 2017
View reviewed changes
Comment thread Doc/library/smtpd.rst Outdated

.. seealso::

The `aiosmtpd <http://aiosmtpd.readthedocs.io/en/latest/>`_ package is a

vstinner Feb 24, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I suggest to drop the /en/latest/ part of the URL.

warsaw Feb 24, 2017

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

WFM, thanks.

vstinner merged commit fba79dc into python:master Feb 24, 2017

vstinner commented Feb 24, 2017

Copy link
Copy Markdown
Member

Yeah, it's time to say goodbye to asyncore :-(

Mariatta commented Feb 24, 2017

Copy link
Copy Markdown
Member

Hm... we don't have needs backport to 3.4 label..

@Haypo I created an issue about replacing asyncore a while back: http://bugs.python.org/issue28533

warsaw deleted the bpo-25008 branch February 24, 2017 20:06

warsaw commented Feb 24, 2017

Copy link
Copy Markdown
Member Author

I guess I'll do the cherry picks. I think they all need merge requests right?

Mariatta commented Feb 24, 2017

Copy link
Copy Markdown
Member

I think they all need merge requests right?
Yes :)

warsaw added a commit to warsaw/cpython that referenced this pull request Feb 24, 2017
bpo-25008: Deprecate smtpd and point to aiosmtpd (python#274)
565be36
warsaw added a commit to warsaw/cpython that referenced this pull request Feb 24, 2017
bpo-25008: Deprecate smtpd and point to aiosmtpd (python#274)
68699fc
warsaw added a commit to warsaw/cpython that referenced this pull request Feb 24, 2017
bpo-25008: Deprecate smtpd and point to aiosmtpd (python#274)
8d6f28f

warsaw commented Feb 24, 2017

Copy link
Copy Markdown
Member Author

@Mariatta It also looks like 3.4 is not a protected branch. I think I can self-approve merges to that branch.

warsaw commented Feb 24, 2017

Copy link
Copy Markdown
Member Author

Or maybe @dstufft was quicker than my browser. :)

warsaw added a commit that referenced this pull request Feb 24, 2017
bpo-25008: Deprecate smtpd and point to aiosmtpd (#274) (#280)
f37b0cb
warsaw added a commit that referenced this pull request Feb 24, 2017
bpo-25008: Deprecate smtpd and point to aiosmtpd (#274) (#278)
0a1b656
warsaw added a commit that referenced this pull request Feb 24, 2017
bpo-25008: Deprecate smtpd and point to aiosmtpd (#274) (#279)
66b5092
jaraco added a commit to jaraco/cpython that referenced this pull request Feb 17, 2023
Merge pull request python#274 from tirkarthi/fix-warnings
b14f9b5 
Fix ResourceWarning due to unclosed file resource.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL