Repository navigation
bpo-44771: Sync with importlib_resources 5.2.2, fixing refleak. - #27497
Merged
jaraco merged 2 commits intoJul 31, 2021
Merged
jaraco merged 2 commits into
jaraco merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
The test failure on buildbot/s390x Fedora Clang Installer PR seems spurious. That package clearly does exist. Does a new package need to be referenced in the makefile or something? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
On further consideration, this isn't spurious and is probably another class of buildbot failures missed in #27436, presumed fixed in c0076d1. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
The reported failure looks unrelated to these changes: ..python: Objects/dictobject.c:350: dictkeys_set_index: Assertion `keys->dk_version == 0' failed. Fatal Python error: Aborted Current thread 0x00007feb08ad2740 (most recent call first): File "/home/buildbot/buildarea/pull_request.cstratak-RHEL7-x86_64.refleak/build/Lib/test/test_importlib/test_api.py", line 290 in test_reload_location_changed File "/home/buildbot/buildarea/pull_request.cstratak-RHEL7-x86_64.refleak/build/Lib/unittest/case.py", line 549 in _callTestMethod File "/home/buildbot/buildarea/pull_request.cstratak-RHEL7-x86_64.refleak/build/Lib/unittest/case.py", line 592 in run File "/home/buildbot/buildarea/pull_request.cstratak-RHEL7-x86_64.refleak/build/Lib/unittest/case.py", line 652 in __call__ File "/home/buildbot/buildarea/pull_request.cstratak-RHEL7-x86_64.refleak/build/Lib/unittest/suite.py", line 122 in run File "/home/buildbot/buildarea/pull_request.cstratak-RHEL7-x86_64.refleak/build/Lib/unittest/suite.py", line 84 in __call__ File "/home/buildbot/buildarea/pull_request.cstratak-RHEL7-x86_64.refleak/build/Lib/unittest/suite.py", line 122 in run File "/home/buildbot/buildarea/pull_request.cstratak-RHEL7-x86_64.refleak/build/Lib/unittest/suite.py", line 84 in __call__ File "/home/buildbot/buildarea/pull_request.cstratak-RHEL7-x86_64.refleak/build/Lib/unittest/suite.py", line 122 in run File "/home/buildbot/buildarea/pull_request.cstratak-RHEL7-x86_64.refleak/build/Lib/unittest/suite.py", line 84 in __call__ File "/home/buildbot/buildarea/pull_request.cstratak-RHEL7-x86_64.refleak/build/Lib/unittest/suite.py", line 122 in run File "/home/buildbot/buildarea/pull_request.cstratak-RHEL7-x86_64.refleak/build/Lib/unittest/suite.py", line 84 in __call__ File "/home/buildbot/buildarea/pull_request.cstratak-RHEL7-x86_64.refleak/build/Lib/unittest/suite.py", line 122 in run File "/home/buildbot/buildarea/pull_request.cstratak-RHEL7-x86_64.refleak/build/Lib/unittest/suite.py", line 84 in __call__ File "/home/buildbot/buildarea/pull_request.cstratak-RHEL7-x86_64.refleak/build/Lib/unittest/runner.py", line 176 in run File "/home/buildbot/buildarea/pull_request.cstratak-RHEL7-x86_64.refleak/build/Lib/test/support/__init__.py", line 979 in _run_suite File "/home/buildbot/buildarea/pull_request.cstratak-RHEL7-x86_64.refleak/build/Lib/test/support/__init__.py", line 1104 in run_unittest File "/home/buildbot/buildarea/pull_request.cstratak-RHEL7-x86_64.refleak/build/Lib/test/libregrtest/runtest.py", line 261 in _test_module File "/home/buildbot/buildarea/pull_request.cstratak-RHEL7-x86_64.refleak/build/Lib/test/libregrtest/refleak.py", line 90 in dash_R File "/home/buildbot/buildarea/pull_request.cstratak-RHEL7-x86_64.refleak/build/Lib/test/libregrtest/runtest.py", line 295 in _runtest_inner2 File "/home/buildbot/buildarea/pull_request.cstratak-RHEL7-x86_64.refleak/build/Lib/test/libregrtest/runtest.py", line 335 in _runtest_inner File "/home/buildbot/buildarea/pull_request.cstratak-RHEL7-x86_64.refleak/build/Lib/test/libregrtest/runtest.py", line 215 in _runtest File "/home/buildbot/buildarea/pull_request.cstratak-RHEL7-x86_64.refleak/build/Lib/test/libregrtest/runtest.py", line 245 in runtest File "/home/buildbot/buildarea/pull_request.cstratak-RHEL7-x86_64.refleak/build/Lib/test/libregrtest/main.py", line 334 in rerun_failed_tests File "/home/buildbot/buildarea/pull_request.cstratak-RHEL7-x86_64.refleak/build/Lib/test/libregrtest/main.py", line 712 in _main File "/home/buildbot/buildarea/pull_request.cstratak-RHEL7-x86_64.refleak/build/Lib/test/libregrtest/main.py", line 655 in main File "/home/buildbot/buildarea/pull_request.cstratak-RHEL7-x86_64.refleak/build/Lib/test/libregrtest/main.py", line 733 in main File "/home/buildbot/buildarea/pull_request.cstratak-RHEL7-x86_64.refleak/build/Lib/test/__main__.py", line 2 in <module> File "/home/buildbot/buildarea/pull_request.cstratak-RHEL7-x86_64.refleak/build/Lib/runpy.py", line 86 in _run_code File "/home/buildbot/buildarea/pull_request.cstratak-RHEL7-x86_64.refleak/build/Lib/runpy.py", line 196 in _run_module_as_main Extension modules: _testmultiphase (total: 1) make: *** [buildbottest] Aborted program finished with exit code 2 elapsedTime=2769.004730 test_reload_location_changed (test.test_importlib.test_api.Source_ReloadTests) ... |
Sorry, something went wrong.
Copy link
Copy Markdown
|
@jaraco: Please replace # with GH- in the commit message next time. Thanks! |
Sorry, something went wrong.
This was referenced Jul 31, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue44771