FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-89114: Allow setting EPOLLEXCLUSIVE on selectors.EpollSelector by dgilman · Pull Request #27819 · python/cpython · GitHub

Repository navigation

gh-89114: Allow setting EPOLLEXCLUSIVE on selectors.EpollSelector - #27819

Closed
dgilman wants to merge 1 commit into
python:mainfrom
dgilman:epollexclusive
Closed

dgilman wants to merge 1 commit into
python:mainfrom
dgilman:epollexclusive

Conversation

dgilman commented Aug 19, 2021 •
edited by serhiy-storchaka
Loading

Copy link
Copy Markdown

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@dgilman

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

dgilman changed the title issue44951: Allow setting EPOLLEXCLUSIVE on selectors.EpollSelector bpo-44951: Allow setting EPOLLEXCLUSIVE on selectors.EpollSelector Aug 19, 2021
Comment thread Lib/selectors.py Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Since this is in a method literally called register, I'd name the new argument simply flags.

Comment thread Lib/selectors.py Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

So far selectors haven't had this but looking at asyncio, ssl, socket, threading, and multiprocessing code, we usually either use properties for both getting and setting a value, or we use both a get_* and a set_* method.

Since we already have get_key and get_map in selectors.py, and there are no public fields nor properties here, I'd change the exclusive getter to an explicit get_exclusive() method.

dgilman commented Sep 11, 2021

Copy link
Copy Markdown
Author

Thanks for the feedback - I think it is best to get a decision made on whether this approach is the way to go (modify the Epoll class) or if it should be an entirely new EpollExclusiveSelector class with no API changes.

dgilman commented Jul 26, 2022

Copy link
Copy Markdown
Author

The latest mailing list post on this issue, summarizing the two approaches and the decision that should be made, is here https://mail.python.org/archives/list/python-dev@python.org/thread/VB2BBUUJENMWPGXGFMON7UQW27ZOBIB7/

python-cla-bot Bot commented Apr 6, 2025

Copy link
Copy Markdown

The following commit authors need to sign the Contributor License Agreement:

python deleted a comment Apr 7, 2025

github-actions Bot commented Apr 9, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 9, 2026
github-actions Bot removed the stale Stale PR or inactive for long period of time. label Aug 12, 2026
serhiy-storchaka changed the title bpo-44951: Allow setting EPOLLEXCLUSIVE on selectors.EpollSelector gh-89114: Allow setting EPOLLEXCLUSIVE on selectors.EpollSelector Aug 12, 2026

ambv commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

This PR has been blocked on an unsigned CLA for more than 12 months and cannot be merged until all commit authors sign. Closing to cull the number of open pull requests. Do not reopen this pull request without signing the CLA first and getting a go-ahead from a triager or core developer on gh-89114.

ambv closed this Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL