FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-42560: tweaks to intro of Tkinter docs- add macOS, drop ActiveState by roseman · Pull Request #27835 · python/cpython · GitHub

Repository navigation

bpo-42560: tweaks to intro of Tkinter docs- add macOS, drop ActiveState - #27835

Merged
ambv merged 1 commit into
python:mainfrom
roseman:tkinter-docs-intro
Aug 22, 2021
Merged

ambv merged 1 commit into
python:mainfrom
roseman:tkinter-docs-intro

Conversation

roseman commented Aug 19, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor
  • explicitly add macOS to platforms
  • drop reference to ActiveState, which is no longer core Tcl/Tk maintainer

https://bugs.python.org/issue42560

Comment thread Doc/library/tkinter.rst
platforms, as well as on Windows systems. (Tk itself is not part of Python; it
is maintained at ActiveState.)
the Tcl/Tk GUI toolkit. Both Tk and :mod:`tkinter` are available on most Unix
platforms, including macOS, as well as on Windows systems.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality
Suggested change
platforms, including macOS, as well as on Windows systems.
platforms (including macOS) as well as on Windows systems.

IMO, this flows better with the following "as well as ..."

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Disagree, as you need the comma before "as well as" for the external flow anyway, as you can see on the red part of the diff.

Copy link
Copy Markdown
Contributor

Thanks @roseman for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

Copy link
Copy Markdown

GH-27891 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 22, 2021
…te (pythonGH-27835)

(cherry picked from commit 141c7a4)

Co-authored-by: Mark Roseman <mark@markroseman.com>

Copy link
Copy Markdown

GH-27892 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 22, 2021
…te (pythonGH-27835)

(cherry picked from commit 141c7a4)

Co-authored-by: Mark Roseman <mark@markroseman.com>
miss-islington added a commit that referenced this pull request Aug 22, 2021
…te (GH-27835)

(cherry picked from commit 141c7a4)

Co-authored-by: Mark Roseman <mark@markroseman.com>
ambv pushed a commit that referenced this pull request Aug 22, 2021
…te (GH-27835) (GH-27892)

(cherry picked from commit 141c7a4)

Co-authored-by: Mark Roseman <mark@markroseman.com>
hpmason mannequin mentioned this pull request Nov 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants


Back | FazBrowse Home | New Git URL