FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-42255: Deprecate webbrowser.MacOSX from Python 3.11 by corona10 · Pull Request #27837 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

bpo-42255: Deprecate webbrowser.MacOSX from Python 3.11 - #27837

Merged
ambv merged 2 commits into
python:mainfrom
corona10:bpo-42255
Sep 3, 2021
ConversationCommits (2)ChecksFiles changed
Merged

bpo-42255: Deprecate webbrowser.MacOSX from Python 3.11#27837
ambv merged 2 commits into
python:mainfrom
corona10:bpo-42255

Conversation

corona10 commented Aug 19, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

corona10 commented Aug 19, 2021
View reviewed changes
Comment thread Doc/library/webbrowser.rst Outdated

corona10 Aug 19, 2021

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This section should be backported

ambv Sep 3, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I don't think we can reasonably call renaming MacOSX to MacOSXOSAScript a "backport" of this PR since it is about the deprecation. I'll of course accept PRs to 3.10 and 3.9 that make this doc change.

corona10 commented Aug 19, 2021
View reviewed changes
Comment thread Doc/library/webbrowser.rst Outdated

corona10 Aug 19, 2021

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This section should be backported

corona10 requested a review from ambv September 1, 2021 03:05

corona10 commented Sep 1, 2021

Copy link
Copy Markdown
Member Author

@ambv Can you please take a look? cc @ned-deily @ronaldoussoren

ambv requested changes Sep 2, 2021
View reviewed changes

ambv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

See PEP 387 for our deprecation policy.

Comment thread Doc/library/webbrowser.rst Outdated
Comment thread Doc/whatsnew/3.11.rst Outdated
Comment thread Misc/NEWS.d/next/Library/2021-08-19-23-49-10.bpo-42255.ofe3ms.rst Outdated

bedevere-bot commented Sep 2, 2021

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

ambv commented Sep 3, 2021

Copy link
Copy Markdown
Contributor

@corona10, please also resolve the conflict with main.

corona10 commented Sep 3, 2021

Copy link
Copy Markdown
Member Author

I have made the requested changes; please review again

bedevere-bot commented Sep 3, 2021

Copy link
Copy Markdown

Thanks for making the requested changes!

@ambv: please review the changes made to this pull request.

bedevere-bot requested a review from ambv September 3, 2021 13:34

ambv commented Sep 3, 2021

Copy link
Copy Markdown
Contributor

@corona10, your force-push undid the changes to 3.13. I'll make them myself since you had them in a035970b79921a66d29688b3a30e5108af3fa82c.

ambv merged commit bc1c49f into python:main Sep 3, 2021
corona10 deleted the bpo-42255 branch September 3, 2021 16:21

corona10 commented Sep 3, 2021 •
edited
Loading

Copy link
Copy Markdown
Member Author

@ambv Thanks :)
I notice it now that I made mistake while rebased on my local environment :(

ronaldoussoren mentioned this pull request May 23, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ronaldoussoren Awaiting requested review from ronaldoussoren
ned-deily Awaiting requested review from ned-deily
ambv Awaiting requested review from ambv

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL