FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-45019: Add a tool to generate list of modules to include for frozen modules by ericsnowcurrently · Pull Request #27980 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

bpo-45019: Add a tool to generate list of modules to include for frozen modules - #27980

Merged
ericsnowcurrently merged 41 commits into
python:mainfrom
ericsnowcurrently:frozen-modules-cleanup
Aug 30, 2021
ConversationCommits (41)ChecksFiles changed
Merged

bpo-45019: Add a tool to generate list of modules to include for frozen modules#27980
ericsnowcurrently merged 41 commits into
python:mainfrom
ericsnowcurrently:frozen-modules-cleanup

Conversation

ericsnowcurrently commented Aug 26, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

Frozen modules must be added to several files in order to work properly. Before this change this had to be done manually. Here we add a tool to generate the relevant lines in those files instead. This helps us avoid mistakes and omissions.

https://bugs.python.org/issue45019

ericsnowcurrently and others added 29 commits August 26, 2021 12:52
Clean up _freeze_importlib.c.
a10471a
_freeze_importlib -> _freeze_module
6252a37
Add tooling to freeze stdlib modules.
b230af8
Support freezing a package's submodules.
e4ef8fc
Use freeze_modules.py for all frozen modules.
6bcc8c9
Regen frozen.c and Makefile.pre.in.
1cae771
Add the updating_file_with_tmpfile() "tool".
ba9417c
Regen frozen.c in place.
6dcb926
Clean up.
8a2b4b7
Add --no-regen.
8ad3c1d
Be consistent about the frozen module filename (frozen_*.h).
1e88d34
Use consistently named make targets for regen-frozen-*.
c4874f2
Drop the stdlib placeholders.
06af093
Simplify FROZEN a little.
3a036b7
Combine FROZEN and MODULES.
6a27a1d
Drop the frozen module groups.
e3e07a9
Fix a typo.
3d2ebdb
Fix the Makefile.
9a5141f
Make freeze_modules.py less fragile.
3687fda
Simplify specs.
1331a77
Explicitly freeze modules in Makefile.
30972b2
Fix a typo.
7a4a876
Fix dependencies.
1306a4e
Drop some dead code.
f724deb
Fix another typo.
9a4d120
Generate the frozen file in-place rather than with a temp file.
54b0116
Update Windows build config.
16adb8e
Move frozen modules into their own directory.
2d51cba
Add a NEWS entry.
5cfd853
ericsnowcurrently mentioned this pull request Aug 26, 2021
Closed
23 of 46 tasks

gvanrossum commented Aug 27, 2021

Copy link
Copy Markdown
Member

Is this ready for review (apart from the failing test)?

gvanrossum self-requested a review August 27, 2021 03:45

ericsnowcurrently commented Aug 27, 2021

Copy link
Copy Markdown
Member Author

Is this ready for review (apart from the failing test)?

Yes.

(I need to figure out why "make regen-keywords" isn't working for me locally. Something about ModuleNotFoundError('dataclasses').)

brettcannon changed the title bpo-45019: Add a tool to generate lines for frozen modules. bpo-45019: Add a tool to generate list of modules to include for frozen modules Aug 27, 2021
gvanrossum reviewed Aug 28, 2021
View reviewed changes

gvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I've only gotten to frozen.c, I'll review the rest later. So far this is great, I just have a few nits about outdated comments.

Comment thread Python/frozen.c Outdated
Comment thread PCbuild/readme.txt Outdated
Comment thread Programs/_freeze_module.c Outdated
Comment thread Programs/_freeze_module.c Outdated
Comment thread Programs/_freeze_module.c Outdated
Comment thread Python/frozen.c Outdated
Comment thread Python/frozen.c Outdated
gvanrossum reviewed Aug 28, 2021
View reviewed changes

gvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Here's the rest. It's looking much better than the version I used for my "codegen" experiments!

Comment thread Python/frozen_modules/hello.h
Comment thread Tools/scripts/freeze_modules.py Outdated
Comment thread Tools/scripts/freeze_modules.py Outdated
Comment thread Tools/scripts/freeze_modules.py
Comment thread Tools/scripts/freeze_modules.py Outdated
Comment thread Tools/scripts/update_file.py
gvanrossum approved these changes Aug 30, 2021
View reviewed changes

gvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM! Do you want any other reviewers? Pablo?

ericsnowcurrently commented Aug 30, 2021

Copy link
Copy Markdown
Member Author

This change is focused on cleanup, so other reviewers probably aren't necessary. The next PR (freezing some of the stdlib modules) might deserve more than one.

ericsnowcurrently merged commit 044e8d8 into python:main Aug 30, 2021
ericsnowcurrently deleted the frozen-modules-cleanup branch August 31, 2021 14:08
ericsnowcurrently mentioned this pull request Sep 13, 2021
Merged
ericsnowcurrently added a commit that referenced this pull request Sep 13, 2021
bpo-45019: Do some cleanup related to frozen modules. (gh-28319)
a2d8c4b 
There are a few things I missed in gh-27980. This is a follow-up that will make subsequent PRs cleaner. It includes fixes to tests and tools that reference the frozen modules.

https://bugs.python.org/issue45019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

gvanrossum gvanrossum approved these changes
brettcannon Awaiting requested review from brettcannon brettcannon is a code owner
encukou Awaiting requested review from encukou
ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner
warsaw Awaiting requested review from warsaw warsaw is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL