Repository navigation
[3.10] bpo-45081: Fix __init__ method generation when inheriting from Protocol (GH-28121) - #28131
Merged
miss-islington merged 1 commit intoSep 3, 2021
Merged
miss-islington merged 1 commit into
miss-islington merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…ol (pythonGH-28121) Co-authored-by: Ken Jin <28750310+Fidget-Spinner@users.noreply.github.com> (cherry picked from commit 0635e20) Co-authored-by: Yurii Karabas <1998uriyyo@gmail.com>
miss-islington
requested review from
Fidget-Spinner,
ericvsmith and
gvanrossum
as code owners
September 2, 2021 16:17
Copy link
Copy Markdown
Contributor
Author
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
@pablogsal, this fixes a regression (that shipped with 3.9.7) where the fix in GH-27545 made dataclass-based classes use the wrong __init__ if they inherited from Protocol too. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
Sorry, something went wrong.
ambv
approved these changes
Sep 3, 2021
ambv
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Regression fix, needs to go in for rc2.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Ken Jin 28750310+Fidget-Spinner@users.noreply.github.com
(cherry picked from commit 0635e20)
Co-authored-by: Yurii Karabas 1998uriyyo@gmail.com
https://bugs.python.org/issue45081