| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). Recognized GitHub usernameWe couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames: This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
Sorry, something went wrong.
|
Should not OSError be used? |
Sorry, something went wrong.
Do you mean in the example itself? |
Sorry, something went wrong.
| File "<stdin>", line 2, in <module> | ||
| File "<stdin>", line 2, in func | ||
| OSError | ||
| IOError |
There was a problem hiding this comment.
You would have thought so, but actually IOError is an alias for OSError and this output is actually correct. I would suggest to replace the exception by some other type which is more suitable for a tutorial example.
Sorry, something went wrong.
There was a problem hiding this comment.
>>> str(IOError) "<class 'OSError'>"
Sorry, something went wrong.
|
Can you create this against the main branch first? Or does it not exist in the main branch? |
Sorry, something went wrong.
|
This PR is stale because it has been open for 30 days with no activity. If the CLA is not signed within 14 days, it will be closed. See also https://devguide.python.org/pullrequest/#licensing |
Sorry, something went wrong.
|
Closing this stale PR because the CLA is still not signed. |
Sorry, something went wrong.
|
Just a note that any IOError / OSError confusion was cleared up in #23160 by replacing it with ConnectionError. Also that was merged in December 2020, 9 months before this was opened. It was probably missed since this opened against the 3.9 branch instead of main. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Just a typo since the code example above indicates that an IOError is thrown, and not an OSError.