bpo-45152: Add HAS_CONST macro and get_const_value() function and use… - #28262
Merged
markshannon merged 3 commits intoSep 14, 2021
Merged
markshannon merged 3 commits into
markshannon merged 3 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
… them instead of explicit LOAD_CONST handling.
isidentical
reviewed
Sep 12, 2021
Comment thread
Python/compile.c
markshannon
requested changes
Sep 13, 2021
Comment thread
Python/compile.c
Outdated
Copy link
Copy Markdown
|
When you're done making the requested changes, leave the comment: I have made the requested changes; please review again. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
@markshannon: Please replace # with GH- in the commit message next time. Thanks! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… them instead of explicit LOAD_CONST handling.
https://bugs.python.org/issue45152