bpo-5846: Do not use obsolete unittest functions. - #28303
Merged
serhiy-storchaka merged 1 commit intoSep 13, 2021
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
serhiy-storchaka
requested review from
a team,
brettcannon,
encukou,
ericsnowcurrently,
ncoghlan and
warsaw
as code owners
September 13, 2021 06:16
erlend-aasland
requested changes
Sep 13, 2021
erlend-aasland
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Please use defaultTestLoader instead of creating a new instance whenever possible.
Sorry, something went wrong.
Get rid of use of makeSuite() and findTestCases(). Also make test_math and test_threading_local discoverable.
serhiy-storchaka
force-pushed
the
unittest-makesuite
branch
from
0ec89e5 to
af2f55f
Compare
September 13, 2021 07:24
erlend-aasland
approved these changes
Sep 13, 2021
erlend-aasland
pushed a commit
to erlend-aasland/cpython
that referenced
this pull request
Sep 13, 2021
Sync with main bco. python#28303
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Get rid of use of makeSuite() and findTestCases().
Also make test_math and test_threading_local discoverable.
https://bugs.python.org/issue5846