Repository navigation
bpo-9566: Silence warning in gcmodule.c caused by pydtrace.h - #2852
Closed
segevfiner wants to merge 1 commit into
Closed
segevfiner wants to merge 1 commit into
segevfiner wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
4 of 5 tasks
Copy link
Copy Markdown
Contributor
|
We shouldn't just change the definition here. Either we need to change the type in pydtrace.d or just pass an int into the trace function in gcmodule.c. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caused by DTrace stubs being defined as taking int. The real one takes a long (Include/pydtrace.d:12), which is probably 64-bit on architectures where DTrace is available but it is 32-bit on Windows x64. It really needs a Py_ssize_t but I'm not familiar enough with DTrace to change pydtrace.d. I think we can simply change the stub to a larger integer type without it causing issues... And maybe if someone really finds an issue he can also change pydtrace.d in the future.
https://bugs.python.org/issue9566