FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-10716: Migrating pydoc to html5. by JulienPalard · Pull Request #28651 · python/cpython · GitHub

Repository navigation

bpo-10716: Migrating pydoc to html5. - #28651

Merged
JulienPalard merged 5 commits into
python:mainfrom
JulienPalard:mdk/pydoc
Oct 9, 2021
Merged

JulienPalard merged 5 commits into
python:mainfrom
JulienPalard:mdk/pydoc

Conversation

JulienPalard commented Sep 30, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

I tried myself at porting pydoc to html5.

I though (hoped?) the commit would be smaller, I tried to keep it as small as possible. I did not tried to enhance the graphical result, I just focused on HTML modernisation as a fist step.

https://bugs.python.org/issue10716

Copy link
Copy Markdown
Member Author

Ohhh, interesting, cgitb depends on pydoc, so if I use css in pydoc... oh wow.

Copy link
Copy Markdown
Member Author

So I modified cgitb a bit to not depend on html rendered by pydoc.

I also had to modify pydoc test which were extremely strict in the output expected, I tried to still check that every bit of important info are given, while not being strict on the HTML used.

Copy link
Copy Markdown
Member Author

TIL about ServerHTMLDoc...

Comment thread Lib/cgitb.py Outdated
Comment thread Lib/pydoc.py Outdated
Comment thread Lib/pydoc.py Outdated
JulienPalard force-pushed the mdk/pydoc branch 2 times, most recently from c4c9cfc to 98a3bc3 Compare September 30, 2021 21:34
serhiy-storchaka added the type-feature A feature request or enhancement label Oct 1, 2021

Copy link
Copy Markdown
Member Author

I'd like to merge this, does someone still want to proof-read first?

merwok commented Oct 7, 2021

Copy link
Copy Markdown
Member

I haven’t had a chance to run it locally to see the results yet.
Maybe you have screenshots?

merwok commented Oct 7, 2021

Copy link
Copy Markdown
Member

This could get a note in the release notes (for pydoc and xmlrpc — cgitb is unchanged)

Copy link
Copy Markdown
Member Author

Here come the screenshots, side by side:


There's a few differences, in the height of the title bar for example.

Copy link
Copy Markdown
Member Author

This could get a note in the release notes (for pydoc and xmlrpc — cgitb is unchanged)

True, done.

Comment thread Lib/test/test_pydoc.py Outdated
Comment thread Lib/test/test_pydoc.py Outdated
Comment thread Lib/test/test_pydoc.py

merwok commented Oct 8, 2021

Copy link
Copy Markdown
Member

Thank you for your efforts in tackling this! It was needed and is the basis for future improvements.

I have added some final questions on some details. (If you make changes, please avoid force-pushing to make reviewing easier.)

JulienPalard merged commit c91b6f5 into python:main Oct 9, 2021
JulienPalard deleted the mdk/pydoc branch October 9, 2021 07:36

Copy link
Copy Markdown
Member Author

Thanks @merwok and @rhettinger for the review!

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type-feature A feature request or enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants


Back | FazBrowse Home | New Git URL