[3.9] bpo-44050: Extension modules can share state when they don't support sub-interpreters. (GH-27794) - #28741
Merged
ambv merged 2 commits intoOct 5, 2021
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…pport sub-interpreters. (pythonGH-27794) Automerge-Triggered-By: GH:encukou. (cherry picked from commit b9bb748) Co-authored-by: Hai Shi <shihai1992@gmail.com>
ambv
requested review from
brettcannon,
encukou,
ericsnowcurrently,
ncoghlan and
warsaw
as code owners
October 5, 2021 16:34
Copy link
Copy Markdown
Member
|
Thanks for taking this, Łukasz! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit b9bb748)
Co-authored-by: Hai Shi shihai1992@gmail.com
Note: this is a little different from 3.10 and 3.11 because in 3.10+ _Py_IsMainInterpreter takes PyInterpreterState instead of the entire PyThreadState as an argument (see GH-24577 for that).
Also, the new test uses PyModule_AddObjectRef which was only added in Python 3.10 (see GH-23122). I replaced this usage with the old PyModule_AddObject with additional increfs and decrefs per what BPO-42327 prescribes.
https://bugs.python.org/issue44050