FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-45391: mark UnionType as a class in documentation by gaborbernat · Pull Request #28757 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

bpo-45391: mark UnionType as a class in documentation - #28757

Merged
Fidget-Spinner merged 1 commit into
python:mainfrom
gaborbernat:45391
Dec 9, 2021
ConversationCommits (1)ChecksFiles changed
Merged

bpo-45391: mark UnionType as a class in documentation#28757
Fidget-Spinner merged 1 commit into
python:mainfrom
gaborbernat:45391

Conversation

gaborbernat commented Oct 6, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor 
❯ sphobjinv suggest ./build/html/objects.inv UnionType
:py:class:`types.UnionType`

Signed-off-by: Bernát Gábor bgabor8@bloomberg.net

https://bugs.python.org/issue45391

Things to consider the type does show up as class now in documentation:

vs before

This PR only addresses the instance in the issue report, but we should discuss if we should change all such instances in this file (there are quite a few others suffering from the same problem).

bpo-45391: UnionType is a class not data
20da064 
Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net>
bedevere-bot added the docs Documentation in the Doc dir label Oct 6, 2021

github-actions Bot commented Nov 6, 2021

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

github-actions Bot added the stale Stale PR or inactive for long period of time. label Nov 6, 2021
merwok changed the title bpo-45391: UnionType is a class not data bpo-45391: make UnionType as a class in documentation Nov 6, 2021
merwok changed the title bpo-45391: make UnionType as a class in documentation bpo-45391: mark UnionType as a class in documentation Nov 6, 2021
Fidget-Spinner approved these changes Dec 9, 2021
View reviewed changes

Fidget-Spinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'm merging this as this is more straightforward than the rest of the list mentioned on the bpo. Those need more deliberation.

Fidget-Spinner merged commit e2cfc89 into python:main Dec 9, 2021

miss-islington commented Dec 9, 2021

Copy link
Copy Markdown
Contributor

Thanks @gaborbernat for the PR, and @Fidget-Spinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 9, 2021
bpo-45391: mark UnionType as a class in documentation (pythonGH-28757)
6e46fab 
Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net>
(cherry picked from commit e2cfc89)

Co-authored-by: Bernát Gábor <gaborjbernat@gmail.com>

bedevere-bot commented Dec 9, 2021

Copy link
Copy Markdown

GH-30004 is a backport of this pull request to the 3.10 branch.

Fidget-Spinner commented Dec 9, 2021

Copy link
Copy Markdown
Member

Thanks @gaborbernat for catching this, and thank you @AlexWaygood for reminding me to check this PR.

miss-islington added a commit that referenced this pull request Dec 9, 2021
bpo-45391: mark UnionType as a class in documentation (GH-28757)
2c2ee83 
Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net>
(cherry picked from commit e2cfc89)

Co-authored-by: Bernát Gábor <gaborjbernat@gmail.com>
gaborbernat mannequin mentioned this pull request Sep 21, 2022
Open
gaborbernat mentioned this pull request May 31, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

serhiy-storchaka serhiy-storchaka approved these changes
Fidget-Spinner Fidget-Spinner approved these changes
AlexWaygood AlexWaygood approved these changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL