Fix typos in the Lib directory by cclauss · Pull Request #28775 · python/cpython · GitHub

Like #28744 but for the Lib directory.

[skip issue] Opening a related issue is pending python/psf-infra-meta#130

codespell --ignore-words-list=aline,alo,ans,asend,atleast,ba,bloc,browseable,cant,crasher,crashers,commen,datas,datea,doesnot,donn,ende,filetest,filetests,fiter,fo,hda,hel,hellow,henc,hist,infinit,inout,interruptable,invokations,ist,ket,lable,larg,leapyear,mye,nams,nd,ned,nin,notmutch,nwe,oder,oll,parm,raison,responsable,seh,simeple,squirl,spawnve,sur,tbe,te,teh,tey,thow,timere,tre,trough,tthe,ue,upto,wile,wont --skip=".decTest,.txt,*.types" Lib

I checked everything, not just idlelib, and all the changes look correct. I checked a few with the handy web search bar. One other check will be sufficient.

The requested change is to change 'gui' to 'GUI' in a line with another correction.

If whoever merges this does not backport to both 3.10 and 3.9, please let me know as I want at least the idlelib changes backported and will do so if necessary.

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>

Except for the one small change I suggest, these all look good to me.

Looks good to me.

There are ~5 of these PRs, see #28745 (comment) for details on how we're handling them. TL;DR - I'm taking the reviews. Backports to 3.9 and 3.10 are being done (manually) to reduce potential for merge conflicts of other bugfix backports.

Thanks @cclauss for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

Sorry, @cclauss and @gpshead, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 745c9d9dfc1ad6fdfdf1d07420c6273ff67fa5be 3.10

Sorry @cclauss and @gpshead, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 745c9d9dfc1ad6fdfdf1d07420c6273ff67fa5be 3.9

Fix typos in the Lib directory as identified by codespell. Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> (cherry picked from commit 745c9d9)

GH-28803 is a backport of this pull request to the 3.9 branch.

Fix typos in the Lib directory as identified by codespell. Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>. (cherry picked from commit 745c9d9) Co-authored-by: Christian Clauss <cclauss@me.com>

GH-28804 is a backport of this pull request to the 3.10 branch.

Fix typos in the Lib directory as identified by codespell. Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> (cherry picked from commit 745c9d9) Automerge-Triggered-By: GH:JulienPalard

Fix typos in the Lib directory as identified by codespell. Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>. (cherry picked from commit 745c9d9) Co-authored-by: Christian Clauss <cclauss@me.com>

Fix typos in the Lib directory as identified by codespell. Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>

Fix typos in the Lib directory

1c5364e

cclauss requested review from a team, 1st1, abalkin, asvetlov, berkerpeksag, cjw296, ericvsmith, ezio-melotti, pganssle, rhettinger, terryjreedy and vsajip as code owners October 6, 2021 20:27

bedevere-bot added the awaiting review label Oct 6, 2021

the-knights-who-say-ni added the CLA signed label Oct 6, 2021

terryjreedy requested changes Oct 6, 2021

View reviewed changes

Comment thread Lib/email/errors.py

Comment thread Lib/idlelib/idle_test/mock_tk.py Outdated

Comment thread Lib/lib2to3/fixes/fix_metaclass.py

bedevere-bot added awaiting changes and removed awaiting review labels Oct 6, 2021

gui —> GUI

41e183a

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>

cclauss requested review from terryjreedy and removed request for a team October 6, 2021 21:16

ericvsmith requested changes Oct 6, 2021

View reviewed changes

Comment thread Lib/test/test_time.py Outdated

fixup! typo

d3b9c8a

cclauss requested a review from ericvsmith October 6, 2021 21:25

ericvsmith approved these changes Oct 6, 2021

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting changes labels Oct 6, 2021

gpshead self-assigned this Oct 6, 2021

gpshead removed the request for review from 1st1 October 6, 2021 22:57

gpshead removed request for rhettinger, terryjreedy and vsajip October 6, 2021 22:57

gpshead added needs backport to 3.9 skip issue skip news docs Documentation in the Doc dir labels Oct 6, 2021

gpshead approved these changes Oct 6, 2021

View reviewed changes

gpshead merged commit 745c9d9 into python:main Oct 6, 2021

bedevere-bot removed the awaiting merge label Oct 6, 2021

cclauss deleted the codespell-Lib branch October 7, 2021 06:01

cclauss mentioned this pull request Oct 7, 2021

Fix typos in the Modules directory #28761

Merged

cclauss added a commit to cclauss/cpython that referenced this pull request Oct 7, 2021

[3.9] Fix typos in the Lib directory (pythonGH-28775 )

628eb16

Fix typos in the Lib directory as identified by codespell. Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> (cherry picked from commit 745c9d9)

bedevere-bot removed the needs backport to 3.9 label Oct 7, 2021

bedevere-bot removed the needs backport to 3.10 label Oct 7, 2021

cjerdonek reviewed Oct 10, 2021

View reviewed changes

Comment thread Lib/asyncio/unix_events.py

cjerdonek reviewed Oct 10, 2021

View reviewed changes

Comment thread Lib/tkinter/test/test_ttk/test_widgets.py

jaraco pushed a commit to jaraco/cpython that referenced this pull request Feb 17, 2023

Fix typos in the Lib directory (pythonGH-28775 )

329ae9d

Fix typos in the Lib directory as identified by codespell. Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>

Fix typos in the Lib directory by cclauss · Pull Request #28775 · python/cpython · GitHub

Repository navigation

Fix typos in the Lib directory - #28775

Fix typos in the Lib directory#28775gpshead merged 3 commits intopython:mainpython/cpython:mainfrom cclauss:codespell-Libcclauss/cpython:codespell-LibCopy head branch name to clipboard

Conversation

cclauss commented Oct 6, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

terryjreedy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bedevere-bot commented Oct 6, 2021

Uh oh!

ericvsmith left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ericvsmith left a comment

Choose a reason for hiding this comment

Uh oh!

gpshead commented Oct 6, 2021

Uh oh!

miss-islington commented Oct 6, 2021

Uh oh!

miss-islington commented Oct 6, 2021

Uh oh!

miss-islington commented Oct 6, 2021

Uh oh!

bedevere-bot commented Oct 7, 2021

Uh oh!

bedevere-bot commented Oct 7, 2021

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Fix typos in the Lib directory#28775
gpshead merged 3 commits into
python:mainfrom
cclauss:codespell-Lib

cclauss commented Oct 6, 2021 •
edited
Loading