FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-45243: Expose SQLite connection limits as `sqlite3.Connection` attributes by erlend-aasland · Pull Request #28790 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

bpo-45243: Expose SQLite connection limits as sqlite3.Connection attributes - #28790

Closed
erlend-aasland wants to merge 5 commits into
python:mainfrom
erlend-aasland:sqlite-limits-as-attributes
ConversationCommits (5)ChecksFiles changed
Closed

bpo-45243: Expose SQLite connection limits as sqlite3.Connection attributes#28790
erlend-aasland wants to merge 5 commits into
python:mainfrom
erlend-aasland:sqlite-limits-as-attributes

Conversation

erlend-aasland commented Oct 7, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

erlend-aasland commented Oct 7, 2021

Copy link
Copy Markdown
Contributor Author

Proposed alternative to #28463.

erlend-aasland mentioned this pull request Oct 7, 2021
Merged
erlend-aasland force-pushed the sqlite-limits-as-attributes branch from e0da443 to a0c1251 Compare October 7, 2021 12:51
erlend-aasland commented Oct 7, 2021
View reviewed changes
Comment thread Modules/_sqlite/connection.c Outdated

erlend-aasland Oct 7, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Casting the limit macros to void * and back again to int is perhaps a little bit too hackish. But it does allow for a single getter/setter.

erlend-aasland force-pushed the sqlite-limits-as-attributes branch from a0c1251 to f4b9fcd Compare October 7, 2021 12:56
erlend-aasland force-pushed the sqlite-limits-as-attributes branch from 5ec4adb to d04794d Compare October 7, 2021 13:29

serhiy-storchaka commented Oct 7, 2021

Copy link
Copy Markdown
Member 
old = con.SQLITE_LIMIT_LENGTH
con.SQLITE_LIMIT_LENGTH = new

does not look nice to me. If go this way, I would prefer

old = con.limit.length
con.limit.length = new

But do we have precedences of such getters and setters in the stdlib?

There are also disadvantages in comparison with traditional getlimit()/setlimit().

  1. setlimit() sets a new limit and returns an old limit at one operation. Atomically (guarded by the GIL).
  2. getlimit()/setlimit() can be used for new limits not supported by the sqlite3 module yet. Just use some numeric constant.

erlend-aasland commented Oct 7, 2021

Copy link
Copy Markdown
Contributor Author

I'm not aware of similar attributes in the stdlib. I have no strong preference regarding this approach and GH-28463. I'm fine with closing this in favour of GH-28463.

erlend-aasland deleted the sqlite-limits-as-attributes branch October 7, 2021 18:47

erlend-aasland commented Oct 7, 2021

Copy link
Copy Markdown
Contributor Author

This approach will be more tedious to maintain. I'm closing this in favour of GH-28463.

erlend-aasland mentioned this pull request May 16, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

berkerpeksag Awaiting requested review from berkerpeksag

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL