bpo-35134: Move classobject.h to Include/cpython/ - #28968
Merged
vstinner merged 1 commit intoOct 15, 2021
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Move classobject.h, context.h, genobject.h and longintrepr.h header files from Include/ to Include/cpython/. Remove redundant "#ifndef Py_LIMITED_API" in context.h. Remove explicit #include "longintrepr.h" in C files. It's not needed, Python.h already includes it.
vstinner
requested review from
a team,
1st1,
markshannon,
rhettinger and
tiran
as code owners
October 15, 2021 07:20
ShivnarenSrinivasan
pushed a commit
to ShivnarenSrinivasan/cpython
that referenced
this pull request
Oct 15, 2021
Move classobject.h, context.h, genobject.h and longintrepr.h header files from Include/ to Include/cpython/. Remove redundant "#ifndef Py_LIMITED_API" in context.h. Remove explicit #include "longintrepr.h" in C files. It's not needed, Python.h already includes it.
tacaswell
added a commit
to tacaswell/cython
that referenced
this pull request
Oct 28, 2021
python/cpython#28968 / 8e5de40f90476249e9a2e5ef135143b5c6a0b512 which is part of implementing https://bugs.python.org/issue35134 moved the header "longintrepr.h" into a sub-folder. The notes on this change suggested to include "Python.h" instead.
tacaswell
added a commit
to tacaswell/cython
that referenced
this pull request
Oct 28, 2021
python/cpython#28968 / 8e5de40f90476249e9a2e5ef135143b5c6a0b512 which is part of implementing https://bugs.python.org/issue35134 moved the header "longintrepr.h" into a sub-folder. The notes on this change suggested to include "Python.h" instead.
scoder
pushed a commit
to cython/cython
that referenced
this pull request
Oct 31, 2021
…H-4428) See python/cpython#28968 which is part of implementing https://bugs.python.org/issue35134 moved the header "longintrepr.h" into a sub-folder. The notes on this change suggested to include "Python.h" instead.
scoder
pushed a commit
to cython/cython
that referenced
this pull request
Oct 31, 2021
…H-4428) See python/cpython#28968 which is part of implementing https://bugs.python.org/issue35134 moved the header "longintrepr.h" into a sub-folder. The notes on this change suggested to include "Python.h" instead.
Closed
1 task
3 tasks
Copy link
Copy Markdown
|
"Remove explicit #include "longintrepr.h" in C files. It's not needed, |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
You can search for # *include.*longintrepr regular expression. For example, on Linux, find -name '*.c' -print0|xargs -0 grep -l -E '# *include.*longintrepr' lists C files which include this header file. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move classobject.h, context.h, genobject.h and longintrepr.h header
files from Include/ to Include/cpython/.
Remove redundant "#ifndef Py_LIMITED_API" in context.h.
Remove explicit #include "longintrepr.h" in C files. It's not needed,
Python.h already includes it.
https://bugs.python.org/issue35134