FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix docs source link for importlib.metadata by flying-sheep · Pull Request #29025 · python/cpython · GitHub

/ cpython Public

Fix docs source link for importlib.metadata - #29025

Merged
miss-islington merged 1 commit into
python:mainfrom
flying-sheep:patch-1
Oct 30, 2021
ConversationCommits (1)ChecksFiles changed
Merged

Fix docs source link for importlib.metadata#29025
miss-islington merged 1 commit into
python:mainfrom
flying-sheep:patch-1

Conversation

flying-sheep commented Oct 18, 2021 •
edited by miss-islington
Loading

Copy link
Copy Markdown
Contributor

The link broke for Python 3.10 since importlib.metadata was made from a module into a package

I think this is trivial enough to not need a bpo issue.

Automerge-Triggered-By: GH:jaraco

bedevere-bot added the docs Documentation in the Doc dir label Oct 18, 2021
FFY00 requested a review from jaraco October 23, 2021 16:09

FFY00 commented Oct 23, 2021

Copy link
Copy Markdown
Member

Ugh, docs are a bit of a pain to keep in sync 😅

FFY00 commented Oct 23, 2021

Copy link
Copy Markdown
Member

@jaraco, remember to change the target branch to main and add the backport label 😁

jaraco commented Oct 23, 2021

Copy link
Copy Markdown
Member

We'll want to apply this change to the cpython branch of importlib_metadata also. Otherwise, it might get overwritten during the next update from there.

jaraco assigned jaraco and unassigned jaraco Oct 23, 2021

FFY00 commented Oct 25, 2021

Copy link
Copy Markdown
Member

The importlib_metadata does not contain this link, it is part of the CPython only header.

jaraco commented Oct 30, 2021

Copy link
Copy Markdown
Member

I applied the change at python/importlib_metadata@90083722648.

jaraco changed the base branch from 3.10 to main October 30, 2021 14:53

jaraco commented Oct 30, 2021

Copy link
Copy Markdown
Member

@jaraco, remember to change the target branch to main and add the backport label 😁

Good catch. I not only had to change the target branch, but I had to cherry-pick and force-push the change against main (because CPython doesn't use the SCM to maintain ancestry of changes).

jaraco added the needs backport to 3.10 only security fixes label Oct 30, 2021

miss-islington commented Oct 30, 2021

Copy link
Copy Markdown
Contributor

@flying-sheep: Status check is done, and it's a success ✅ .

miss-islington merged commit aae18a1 into python:main Oct 30, 2021

miss-islington commented Oct 30, 2021

Copy link
Copy Markdown
Contributor

Thanks @flying-sheep for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 30, 2021
Fix docs source link for importlib.metadata (pythonGH-29025)
7f6f2dd 
The link broke for Python 3.10 since importlib.metadata was made from a module into a package

I think this is trivial enough to not need a bpo issue.

Automerge-Triggered-By: GH:jaraco
(cherry picked from commit aae18a1)

Co-authored-by: Philipp A <flying-sheep@web.de>

bedevere-bot commented Oct 30, 2021

Copy link
Copy Markdown

GH-29330 is a backport of this pull request to the 3.10 branch.

bedevere-bot removed the needs backport to 3.10 only security fixes label Oct 30, 2021
miss-islington added a commit that referenced this pull request Oct 30, 2021
Fix docs source link for importlib.metadata (GH-29025)
da222b7 
The link broke for Python 3.10 since importlib.metadata was made from a module into a package

I think this is trivial enough to not need a bpo issue.

Automerge-Triggered-By: GH:jaraco
(cherry picked from commit aae18a1)

Co-authored-by: Philipp A <flying-sheep@web.de>
flying-sheep deleted the patch-1 branch October 30, 2021 15:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jaraco jaraco approved these changes
FFY00 FFY00 approved these changes
1st1 Awaiting requested review from 1st1
abalkin Awaiting requested review from abalkin
asvetlov Awaiting requested review from asvetlov
berkerpeksag Awaiting requested review from berkerpeksag
brettcannon Awaiting requested review from brettcannon
cjw296 Awaiting requested review from cjw296
encukou Awaiting requested review from encukou
ericsnowcurrently Awaiting requested review from ericsnowcurrently
ericvsmith Awaiting requested review from ericvsmith
ethanfurman Awaiting requested review from ethanfurman
ezio-melotti Awaiting requested review from ezio-melotti
Fidget-Spinner Awaiting requested review from Fidget-Spinner
gpshead Awaiting requested review from gpshead
gvanrossum Awaiting requested review from gvanrossum
isidentical Awaiting requested review from isidentical
lysnikolaou Awaiting requested review from lysnikolaou
markshannon Awaiting requested review from markshannon
methane Awaiting requested review from methane
ncoghlan Awaiting requested review from ncoghlan
pablogsal Awaiting requested review from pablogsal
pganssle Awaiting requested review from pganssle
rhettinger Awaiting requested review from rhettinger
terryjreedy Awaiting requested review from terryjreedy
tiran Awaiting requested review from tiran
vsajip Awaiting requested review from vsajip
warsaw Awaiting requested review from warsaw warsaw is a code owner

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL