FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-45514: Deprecate importlib resources legacy functions. by jaraco · Pull Request #29036 · python/cpython · GitHub

Repository navigation

bpo-45514: Deprecate importlib resources legacy functions. - #29036

Merged
jaraco merged 5 commits into
mainfrom
bpo-45514/deprecate-importlib-resources-legacy
Nov 24, 2021
Merged

jaraco merged 5 commits into
mainfrom
bpo-45514/deprecate-importlib-resources-legacy

Conversation

jaraco commented Oct 18, 2021 •
edited
Loading

Copy link
Copy Markdown
Member
  • bpo-45514: Apply changes from importlib_resources@a3ef4128c6
  • Add blurb

Still to do:

https://bugs.python.org/issue45514

jaraco requested a review from rhettinger as a code owner October 18, 2021 18:26
jaraco removed the request for review from rhettinger October 18, 2021 18:27
jaraco marked this pull request as draft October 18, 2021 18:27
Comment thread Lib/importlib/_adapters.py Outdated
jaraco marked this pull request as ready for review October 18, 2021 19:23

jaraco commented Oct 18, 2021

Copy link
Copy Markdown
Member Author

While this PR is ready for review, I want to wait a few days for importlib_resources 5.3 to be in the wild to ensure there aren't any major emergent concerns.

Co-authored-by: Filipe Laíns <lains@riseup.net>
jaraco requested review from brettcannon and warsaw October 31, 2021 14:04

jaraco commented Oct 31, 2021 •
edited
Loading

Copy link
Copy Markdown
Member Author

I've requested a review of this change with Barry and Brett, both of whom have had substantial influence on this interface and both of whom are on the SC. In this discussion, I've made the case that the deprecation is appropriate, but others have made the case that the deprecation happens too quickly, mainly because there won't be one interface that one could depend on across Python 3.13 and 3.8 without adopting a backport.

If either agree the deprecation is too aggressive, I'll back it out to a PendingDeprecationWarning and let it linger indefinitely.

jaraco commented Oct 31, 2021

Copy link
Copy Markdown
Member Author

While this PR is ready for review, I want to wait a few days for importlib_resources 5.3 to be in the wild to ensure there aren't any major emergent concerns.

There have been no reported issues after issuing the deprecation warning in importlib_resources 5.3.

jaraco commented Nov 14, 2021

Copy link
Copy Markdown
Member Author

I'd like for this change to be present in early releases of Python 3.11 to limit any surprise and get feedback early. I'd prefer to get a review of this change by next week. Please let me know if you would like more time to consider. If I don't hear anything by 2021-11-20 AOE, I'll plan to merge, but without prejudice; the change can be rolled back or dialed back as needed.

Copy link
Copy Markdown
Member

I don't have time to really weigh in on this, so consider me neutral.

brettcannon removed their request for review November 16, 2021 19:38

jaraco commented Nov 24, 2021

Copy link
Copy Markdown
Member Author

I've decided to move forward with this change, with my rationale here.

jaraco removed the request for review from warsaw November 24, 2021 07:49
jaraco merged commit d5cd2ef into main Nov 24, 2021
jaraco deleted the bpo-45514/deprecate-importlib-resources-legacy branch November 24, 2021 07:51
remykarem pushed a commit to remykarem/cpython that referenced this pull request Dec 7, 2021
…29036)

* bpo-45514: Apply changes from importlib_resources@a3ef4128c6

* Mark legacy functions as deprecated in the docs and link to the migration docs in importlib_resources docs.

* Apply changes from importlib_resources@329ae9d5f2c.

* Indicate importlib.resources as a module.

Co-authored-by: Filipe Laíns <lains@riseup.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL