FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-45516: add protocol description to the Traversable documentation by FFY00 · Pull Request #29039 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

bpo-45516: add protocol description to the Traversable documentation - #29039

Merged
jaraco merged 4 commits into
python:mainfrom
FFY00:bpo-45516-traversable
Oct 18, 2021
ConversationCommits (4)ChecksFiles changed
Merged

bpo-45516: add protocol description to the Traversable documentation#29039
jaraco merged 4 commits into
python:mainfrom
FFY00:bpo-45516-traversable

Conversation

FFY00 commented Oct 18, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

FFY00 force-pushed the bpo-45516-traversable branch from d0a9fab to 13a6e1c Compare October 18, 2021 19:12
FFY00 requested a review from jaraco October 18, 2021 19:13

FFY00 commented Oct 18, 2021

Copy link
Copy Markdown
Member Author

We can backport this, right?

jaraco reviewed Oct 18, 2021
View reviewed changes
Comment thread Lib/importlib/abc.py Outdated

jaraco commented Oct 18, 2021

Copy link
Copy Markdown
Member

We can backport this, right?

Not exactly. Docs aren't synced between CPython and importlib_resources, so including this additional detail is going to require adding a lot more unsynchronized reference material to importlib_resources. It's probably not worth it. Let's just maintain the reference material here.

jaraco reviewed Oct 18, 2021
View reviewed changes
Comment thread Doc/library/importlib.rst Outdated
FFY00 and others added 2 commits October 18, 2021 21:06
Update Doc/library/importlib.rst
72af3c9 
Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
Update Lib/importlib/abc.py
76b0cb3
jaraco reviewed Oct 18, 2021
View reviewed changes
Comment thread Doc/library/importlib.rst Outdated

FFY00 commented Oct 18, 2021

Copy link
Copy Markdown
Member Author

Sounds good 😊

Update Doc/library/importlib.rst
cd2ef1e 
Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
jaraco merged commit 4d03de3 into python:main Oct 18, 2021

bedevere-bot commented Oct 18, 2021

Copy link
Copy Markdown

@jaraco: Please replace # with GH- in the commit message next time. Thanks!

FFY00 mentioned this pull request Oct 22, 2021
Closed

jaraco commented Oct 31, 2021

Copy link
Copy Markdown
Member

We can backport this, right?

Not exactly. Docs aren't synced between CPython and importlib_resources, so including this additional detail is going to require adding a lot more unsynchronized reference material to importlib_resources. It's probably not worth it. Let's just maintain the reference material here.

Wait. Did you mean backport to importlib_resources or backport to Python 3.10/3.9? If the latter, then probably yes.

FFY00 commented Oct 31, 2021 •
edited
Loading

Copy link
Copy Markdown
Member Author

The later, I wasn't sure since you maintain a cpython branch.

miss-islington commented Oct 31, 2021

Copy link
Copy Markdown
Contributor

Thanks @FFY00 for the PR, and @jaraco for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

miss-islington commented Oct 31, 2021

Copy link
Copy Markdown
Contributor

Thanks @FFY00 for the PR, and @jaraco for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 31, 2021
bpo-45516: add protocol description to the Traversable documentation (p…
7d5992e 
…ythonGH-29039)

* bpo-45516: add protocol description to the Traversable documentation

Signed-off-by: Filipe Laíns <lains@riseup.net>

* Update Doc/library/importlib.rst

Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>

* Update Lib/importlib/abc.py

* Update Doc/library/importlib.rst

Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>

Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
(cherry picked from commit 4d03de3)

Co-authored-by: Filipe Laíns <filipe.lains@gmail.com>

bedevere-bot commented Oct 31, 2021

Copy link
Copy Markdown

GH-29348 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 31, 2021
bpo-45516: add protocol description to the Traversable documentation (p…
8f0acf7 
…ythonGH-29039)

* bpo-45516: add protocol description to the Traversable documentation

Signed-off-by: Filipe Laíns <lains@riseup.net>

* Update Doc/library/importlib.rst

Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>

* Update Lib/importlib/abc.py

* Update Doc/library/importlib.rst

Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>

Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
(cherry picked from commit 4d03de3)

Co-authored-by: Filipe Laíns <filipe.lains@gmail.com>

bedevere-bot commented Oct 31, 2021

Copy link
Copy Markdown

GH-29349 is a backport of this pull request to the 3.10 branch.

miss-islington added a commit that referenced this pull request Oct 31, 2021
bpo-45516: add protocol description to the Traversable documentation (G…
89b1237 
…H-29039)

* bpo-45516: add protocol description to the Traversable documentation

Signed-off-by: Filipe Laíns <lains@riseup.net>

* Update Doc/library/importlib.rst

Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>

* Update Lib/importlib/abc.py

* Update Doc/library/importlib.rst

Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>

Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
(cherry picked from commit 4d03de3)

Co-authored-by: Filipe Laíns <filipe.lains@gmail.com>
miss-islington added a commit that referenced this pull request Oct 31, 2021
bpo-45516: add protocol description to the Traversable documentation (G…
b04b307 
…H-29039)

* bpo-45516: add protocol description to the Traversable documentation

Signed-off-by: Filipe Laíns <lains@riseup.net>

* Update Doc/library/importlib.rst

Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>

* Update Lib/importlib/abc.py

* Update Doc/library/importlib.rst

Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>

Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
(cherry picked from commit 4d03de3)

Co-authored-by: Filipe Laíns <filipe.lains@gmail.com>
FFY00 mentioned this pull request Apr 10, 2022
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jaraco jaraco approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL