FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[3.9] bpo-45520: Backport __getstate__, __setstate__ methods for `dataclasses` from 3.10 into 3.9 (GH-25786) by sobolevn · Pull Request #29147 · python/cpython · GitHub

Repository navigation

Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension .py  (2) .rst  (1) All 2 file types selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
Next Next commit
[3.9] bpo-45520: Backport __getstate__, __setstate__ methods from…
… 3.10 into 3.9 (GH-25786)
  • Loading branch information
sobolevn committed Oct 22, 2021
commit 71afa4414f2c3b4f1cb0e1dd643e0fe11d502287
19 changes: 19 additions & 0 deletions Lib/dataclasses.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Original file line number Diff line number Diff line change
Expand Up @@ -977,6 +977,10 @@ def _process_class(cls, init, repr, eq, order, unsafe_hash, frozen):
raise TypeError(f'Cannot overwrite attribute {fn.__name__} '
f'in class {cls.__name__}')

# Need this for pickling frozen classes.
cls.__getstate__ = _dataclass_getstate
cls.__setstate__ = _dataclass_setstate

# Decide if/how we're going to create a hash function.
hash_action = _hash_action[bool(unsafe_hash),
bool(eq),
Expand All @@ -995,6 +999,21 @@ def _process_class(cls, init, repr, eq, order, unsafe_hash, frozen):
return cls


# _dataclass_getstate and _dataclass_setstate are needed for pickling frozen
# classes (maybe even with slots).
# These could be slightly more performant if we generated
# the code instead of iterating over fields. But that can be a project for
# another day, if performance becomes an issue.
def _dataclass_getstate(self):
return [getattr(self, f.name) for f in fields(self)]


def _dataclass_setstate(self, state):
for field, value in zip(fields(self), state):
# use setattr because dataclass may be frozen
object.__setattr__(self, field.name, value)


def dataclass(cls=None, /, *, init=True, repr=True, eq=True, order=False,
unsafe_hash=False, frozen=False):
"""Returns the same class as was passed in, with dunder methods
Expand Down
25 changes: 25 additions & 0 deletions Lib/test/test_dataclasses.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Original file line number Diff line number Diff line change
Expand Up @@ -2775,6 +2775,31 @@ class Derived(Base):
# We can add a new field to the derived instance.
d.z = 10

# Can't be local to test_frozen_pickle.
@dataclass(frozen=True)
class FrozenSlotsClass:
__slots__ = ('foo', 'bar')
foo: str
bar: int

@dataclass(frozen=True)
class FrozenWithoutSlotsClass:
foo: str
bar: int

def test_frozen_pickle(self):
# bpo-43999
# bpo-45520

assert self.FrozenSlotsClass.__slots__ == ("foo", "bar")
for proto in range(pickle.HIGHEST_PROTOCOL + 1):
with self.subTest(proto=proto):
p = pickle.dumps(self.FrozenSlotsClass("a", 1), protocol=proto)
assert pickle.loads(p) == self.FrozenSlotsClass("a", 1)

p = pickle.dumps(self.FrozenWithoutSlotsClass("a", 1), protocol=proto)
assert pickle.loads(p) == self.FrozenWithoutSlotsClass("a", 1)

class TestDescriptors(unittest.TestCase):
def test_set_name(self):
# See bpo-33141.
Expand Down
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Fix ``__getstate__`` and ``__setstate__`` methods for frozen
``dataclasses``. It basically backports a part of 3.10's code to support
``pickle`` and ``deepcopy``.

Back | FazBrowse Home | New Git URL