FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-45613: Set `sqlite3.threadsafety` dynamically by erlend-aasland · Pull Request #29227 · python/cpython · GitHub

/ cpython Public

bpo-45613: Set sqlite3.threadsafety dynamically - #29227

Merged
pablogsal merged 16 commits into
python:mainfrom
erlend-aasland:sqlite-threadsafety
Nov 3, 2021
ConversationCommits (16)ChecksFiles changed
Merged

bpo-45613: Set sqlite3.threadsafety dynamically#29227
pablogsal merged 16 commits into
python:mainfrom
erlend-aasland:sqlite-threadsafety

Conversation

erlend-aasland commented Oct 26, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Use the compile-time selected default SQLite threaded mode to set the
DB-API 2.0 attribute 'threadsafety' during sqlite3 module initialisation.

SQLite to DB-API mappings:

  • SQLITE_THREADSAFE=0 => threadsafety=0 (single-thread mode)
  • SQLITE_THREADSAFE=1 => threadsafety=3 (fully threadsafe)
  • SQLITE_THREADSAFE=2 => threadsafety=1 (threadsafe at module level)

https://bugs.python.org/issue45613

Erlend E. Aasland added 2 commits October 26, 2021 14:26
bpo-45613: Dynamically set sqlite3.threadsafety
bf9677c 
Use the compile-time selected default SQLite threaded mode to set the
DB-API 2.0 attribute 'threadsafety'

Mappings:
  - SQLITE_THREADSAFE=0 => threadsafety=0
  - SQLITE_THREADSAFE=1 => threadsafety=3
  - SQLITE_THREADSAFE=2 => threadsafety=1
Add NEWS and What's New
9747c80

erlend-aasland commented Oct 26, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

On hold till #29129 is merged. Will rebase and update docs before marking this as ready for review.

erlend-aasland marked this pull request as draft October 28, 2021 07:12
erlend-aasland marked this pull request as ready for review October 28, 2021 20:46
erlend-aasland added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 29, 2021

bedevere-bot commented Oct 29, 2021

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit 396abd4 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 29, 2021

erlend-aasland commented Oct 29, 2021

Copy link
Copy Markdown
Contributor Author

Testing with buildbots to verify that this approach works across different SQLite versions/configurations. I've verified locally that it works with SQLite 3.7.15 (oldest supported), 3.36.0, and current 3.37.0 (dev).

erlend-aasland commented Nov 2, 2021
View reviewed changes
Comment thread Modules/_sqlite/module.c
erlend-aasland added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 2, 2021

bedevere-bot commented Nov 2, 2021

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit 686d70f 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 2, 2021
erlend-aasland commented Nov 2, 2021
View reviewed changes
Comment thread Doc/library/sqlite3.rst
malemburg approved these changes Nov 3, 2021
View reviewed changes

malemburg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think the patch is good to go as-is, without the additional changes you mentioned in the comments. Thanks, Erlend.

Comment thread Doc/library/sqlite3.rst
Comment thread Modules/_sqlite/module.c

erlend-aasland commented Nov 3, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

I think the patch is good to go as-is, without the additional changes you mentioned in the comments. Thanks, Erlend.

Thanks! There is one change I'd like to make before merging, though: add a versionchanged annotation to the threadsafety attribute doc.

pablogsal approved these changes Nov 3, 2021
View reviewed changes

pablogsal left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

@malemburg do you have anything else you would like here to be addressed?

Edit: ah, I just saw that you approved before. I am landing this then

pablogsal merged commit c273986 into python:main Nov 3, 2021
erlend-aasland deleted the sqlite-threadsafety branch November 3, 2021 21:01

erlend-aasland commented Nov 3, 2021

Copy link
Copy Markdown
Contributor Author

Thanks, Marc-Andre & Pablo 🙏🏻

erlend-aasland mentioned this pull request May 16, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

malemburg malemburg approved these changes
pablogsal pablogsal approved these changes
berkerpeksag Awaiting requested review from berkerpeksag

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL