FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-42064: Adapt `sqlite3` to multi-phase init (PEP 489) by erlend-aasland · Pull Request #29234 · python/cpython · GitHub

Repository navigation

bpo-42064: Adapt sqlite3 to multi-phase init (PEP 489) - #29234

Merged
encukou merged 3 commits into
python:mainfrom
erlend-aasland:sqlite-multiphase-init
Nov 2, 2021
Merged

encukou merged 3 commits into
python:mainfrom
erlend-aasland:sqlite-multiphase-init

Conversation

erlend-aasland commented Oct 27, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

erlend-aasland commented Oct 27, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor Author
$ cat measure.py
import gc
import sys

for _ in range(5):
    gc.collect()
    before = sys.gettotalrefcount()

    import sqlite3
    del sys.modules['sqlite3']
    del sqlite3

    gc.collect()
    after = sys.gettotalrefcount()

    print(f"{before=}, {after=}")

$ ./python.exe measure.py
before=51469, after=66883
before=66892, after=66892
before=66892, after=66892
before=66892, after=66892
before=66892, after=66892 

Thank you so much for helping reviewing and improving this, @corona10, @vstinner, @encukou!

For a list of PR's:
$ git log --grep "bpo-\(42064\|41861\|40956\|42862\)" --oneline

Copy link
Copy Markdown
Contributor Author

See GH-29230 regarding the docs CI failure.

encukou commented Oct 27, 2021

Copy link
Copy Markdown
Member

See GH-29230 regarding the docs CI failure.

PRs can't be merged without passing tests. Could you merge the main branch in?

encukou merged commit 401272e into python:main Nov 2, 2021
erlend-aasland deleted the sqlite-multiphase-init branch November 2, 2021 18:02

vstinner commented Nov 9, 2021

Copy link
Copy Markdown
Member

Nice! Well done @erlend-aasland!

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL