FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-45655: Add "relevant PEPs" section to ``typing`` documentation by AlexWaygood · Pull Request #29280 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

bpo-45655: Add "relevant PEPs" section to typing documentation - #29280

Merged
ambv merged 4 commits into
python:mainfrom
AlexWaygood:typing-docs
Oct 28, 2021
ConversationCommits (4)ChecksFiles changed
Merged

bpo-45655: Add "relevant PEPs" section to typing documentation#29280
ambv merged 4 commits into
python:mainfrom
AlexWaygood:typing-docs

Conversation

AlexWaygood commented Oct 28, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

The list of PEPs at the top of the documentation for the typing module has
become too long to be readable. This PR proposes presenting this
information in a more structured and readable way by adding a new "relevant
PEPs" section to the typing docs.

https://bugs.python.org/issue45655

bpo-45655: Add "relevant PEPs" section to typing documentation
214cee9 
The list of PEPs at the top of the documentation for the ``typing`` module has
become too long to be readable. This PR proposes presenting this
information in a more structured and readable way by adding a new "relevant
PEPs" section to the ``typing`` docs.
bedevere-bot added docs Documentation in the Doc dir awaiting review labels Oct 28, 2021
ambv reviewed Oct 28, 2021
View reviewed changes
Comment thread Doc/library/typing.rst

ambv commented Oct 28, 2021

Copy link
Copy Markdown
Contributor

We can backport to 3.9 but we need to modify the backport to remove 3.10 PEPs.

ambv merged commit 03db1bb into python:main Oct 28, 2021

miss-islington commented Oct 28, 2021

Copy link
Copy Markdown
Contributor

Thanks @AlexWaygood for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 28, 2021
bpo-45655: Add "relevant PEPs" section to typing documentation (p…
ed836d7 
…ythonGH-29280)

The list of PEPs at the top of the documentation for the ``typing`` module has
become too long to be readable. This PR proposes presenting this
information in a more structured and readable way by adding a new "relevant
PEPs" section to the ``typing`` docs.

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
(cherry picked from commit 03db1bb)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>

miss-islington commented Oct 28, 2021

Copy link
Copy Markdown
Contributor

Sorry, @AlexWaygood and @ambv, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 03db1bbfd2d3f5a343c293b2f0e09a1e962df7ea 3.9

bedevere-bot commented Oct 28, 2021

Copy link
Copy Markdown

GH-29290 is a backport of this pull request to the 3.10 branch.

ambv commented Oct 28, 2021

Copy link
Copy Markdown
Contributor

@AlexWaygood, since the change is already conflicting, can you recreate it manually against 3.9?

AlexWaygood commented Oct 28, 2021

Copy link
Copy Markdown
Member Author

@AlexWaygood, since the change is already conflicting, can you recreate it manually against 3.9?

Sure, I'll have a go! (Thanks for the lightning speed in merging! 😀)

AlexWaygood added a commit to AlexWaygood/cpython that referenced this pull request Oct 28, 2021
[3.9] bpo-45655: Add "relevant PEPs" section to typing documentation
7bd5b3d 
Backport of python#29280 to the 3.9 branch.
AlexWaygood mentioned this pull request Oct 28, 2021
Merged

AlexWaygood commented Oct 28, 2021

Copy link
Copy Markdown
Member Author

@AlexWaygood, since the change is already conflicting, can you recreate it manually against 3.9?

3.9 backport here #29297 😊

ambv pushed a commit that referenced this pull request Oct 28, 2021
[3.9] bpo-45655: Add "relevant PEPs" section to typing documentation (G…
8813a98 
…H-29297)

Backport of #29280 to the 3.9 branch.
AlexWaygood added a commit to AlexWaygood/cpython that referenced this pull request Oct 28, 2021
[3.10] bpo-45655: Add "relevant PEPs" section to typing documenta…
33ab63e 
…tion

Backport of python#29280 to the 3.10 branch.
AlexWaygood mentioned this pull request Oct 28, 2021
Merged

AlexWaygood commented Oct 29, 2021

Copy link
Copy Markdown
Member Author

GH-29290 is a backport of this pull request to the 3.10 branch.

This backport has been closed in favour of #29302, which is a new backport to the 3.10 branch

AlexWaygood deleted the typing-docs branch October 29, 2021 10:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ambv ambv left review comments
Fidget-Spinner Awaiting requested review from Fidget-Spinner
gvanrossum Awaiting requested review from gvanrossum

Assignees

ambv

Labels

docs Documentation in the Doc dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL