Repository navigation
bpo-29110: add test for Aifc_write. - #293
Merged
methane merged 3 commits intoFeb 26, 2017
Merged
methane merged 3 commits into
methane merged 3 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Comment thread
Lib/aifc.py
Outdated
|
|
||
| def close(self): | ||
| file = self._file | ||
| file = getattr(self, '_file') |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
It is easier and more reliable to set a class attribute _file = None. This also helps when __del__ is called after clearing the builtins module. This is common idiom.
Sorry, something went wrong.
Comment thread
Lib/aifc.py
Outdated
| # _ssnd_chunk -- instantiation of a chunk class for the SSND chunk | ||
| # _framesize -- size of one frame in the file | ||
|
|
||
| _file = None |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Maybe add a comment like in subprocess.py, tempfile.py, zipfile.py?
Sorry, something went wrong.
serhiy-storchaka
approved these changes
Feb 26, 2017
methane
added a commit
to methane/cpython
that referenced
this pull request
Feb 26, 2017
follow up of pythonGH-162 (cherry picked from commit 5dc33ee)
This was referenced Feb 26, 2017
methane
added a commit
to methane/cpython
that referenced
this pull request
Feb 26, 2017
follow up of pythonGH-162 (cherry picked from commit 5dc33ee)
jaraco
pushed a commit
that referenced
this pull request
Dec 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: https://github.com/python/cpython/pull/162/files#r102688420