Repository navigation
[3.10] makefile: remove unused SGI_ABI variable (GH-29325) - #29368
Merged
ambv merged 1 commit intoNov 2, 2021
Merged
ambv merged 1 commit into
ambv merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
SGI_ABI support was removed in [1] but this variable was never removed from the makefile. Currently, it is just a bad variable that does not get replaced by the configure script. [1] python#3294 Signed-off-by: Filipe Laíns <lains@riseup.net> (cherry picked from commit 38982ab) Co-authored-by: Filipe Laíns <lains@riseup.net>
Copy link
Copy Markdown
Contributor
Author
Sorry, something went wrong.
1 similar comment
Copy link
Copy Markdown
Contributor
Author
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SGI_ABI support was removed in [1] but this variable was never removed
from the makefile. Currently, it is just a bad variable that does not
get replaced by the configure script.
[1] #3294
Signed-off-by: Filipe Laíns lains@riseup.net
(cherry picked from commit 38982ab)
Co-authored-by: Filipe Laíns lains@riseup.net