bpo-45711: Use _PyErr_ClearExcState instead of setting only exc_value… - #29404
Merged
iritkatriel merged 2 commits intoNov 10, 2021
Merged
bpo-45711: Use _PyErr_ClearExcState instead of setting only exc_value…#29404iritkatriel merged 2 commits into
iritkatriel merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
iritkatriel
requested review from
1st1,
cjerdonek,
gvanrossum and
markshannon
November 4, 2021 13:24
iritkatriel
commented
Nov 7, 2021
Comment thread
Modules/_asynciomodule.c
| /* Transfer ownership of exc_value from exc_state to exc since we are | ||
| done with it. */ | ||
| PyException_SetContext(exc, exc_state->exc_value); | ||
| exc_state->exc_value = NULL; |
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
Note that PyErr_Occurred checks whether the type is NULL, not the value. So setting just the value to NULL here doesn't follow the interpreter's semantics for the triplet.
Sorry, something went wrong.
gvanrossum
reviewed
Nov 7, 2021
Comment thread
Modules/_asynciomodule.c
Outdated
asvetlov
approved these changes
Nov 10, 2021
asvetlov
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM, the PR is correct.
Sorry, something went wrong.
gvanrossum
approved these changes
Nov 10, 2021
remykarem
pushed a commit
to remykarem/cpython
that referenced
this pull request
Dec 7, 2021
remykarem
pushed a commit
to remykarem/cpython
that referenced
this pull request
Jan 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… to NULL
This PR tidies up exception handling in Future/Task._make_cancelled_error to make it clearer what's happening and pave the way for a refactor of how the interpreter represents exceptions.
https://bugs.python.org/issue45711