FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-45723: Detect missing pkg-config (GH-29442) by tiran · Pull Request #29442 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

bpo-45723: Detect missing pkg-config (GH-29442) - #29442

Merged
tiran merged 4 commits into
python:mainfrom
tiran:bpo-45723-pkgconf
Nov 7, 2021
ConversationCommits (4)ChecksFiles changed
Merged

bpo-45723: Detect missing pkg-config (GH-29442)#29442
tiran merged 4 commits into
python:mainfrom
tiran:bpo-45723-pkgconf

Conversation

tiran commented Nov 6, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

tiran requested review from ned-deily and pablogsal November 6, 2021 16:04
tiran changed the title Detect missing pkg-config bpo-45723: Detect missing pkg-config Nov 6, 2021
pablogsal reviewed Nov 6, 2021
View reviewed changes
Comment thread configure Outdated
tiran force-pushed the bpo-45723-pkgconf branch from af36054 to 2fa083d Compare November 6, 2021 16:58
ned-deily reviewed Nov 6, 2021
View reviewed changes

ned-deily left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Where is AC_PATH_TOOL being picked up from? The current PR doesn't work for me.

ned-deily commented Nov 6, 2021

Copy link
Copy Markdown
Member 
[...]
config.status: creating pyconfig.h
creating Modules/Setup.local
creating Makefile

pkg-config is missing. Some dependencies may not be detected correctly.


If you want a release build with all stable optimizations active (PGO, etc),
please run ./configure --enable-optimizations


$ pkg-config
Must specify package names on the command line
$ which pkg-config
/usr/bin/pkg-config

This is on a reasonably vanilla Debian system. Also the same on macOS with pkg-config installed from MacPorts.

tiran commented Nov 6, 2021 •
edited
Loading

Copy link
Copy Markdown
Member Author

Strange ... could you please paste the output of grep PKG_CONFIG config.log ?

My system (Fedora 34):

$ grep PKG_CONFIG config.log 
ac_cv_env_PKG_CONFIG_LIBDIR_set=
ac_cv_env_PKG_CONFIG_LIBDIR_value=
ac_cv_env_PKG_CONFIG_PATH_set=
ac_cv_env_PKG_CONFIG_PATH_value=
ac_cv_env_PKG_CONFIG_set=
ac_cv_env_PKG_CONFIG_value=
ac_cv_path_ac_pt_PKG_CONFIG=/usr/bin/pkg-config
ac_cv_prog_ac_ct_PKG_CONFIG=/usr/bin/pkg-config
PKG_CONFIG='/usr/bin/pkg-config'
PKG_CONFIG_LIBDIR=''
PKG_CONFIG_PATH=''

tiran commented Nov 6, 2021

Copy link
Copy Markdown
Member Author

Where is AC_PATH_TOOL being picked up from? The current PR doesn't work for me.

AC_PATH_TOOL is provided by autoconf/programs.m4.

tiran commented Nov 6, 2021

Copy link
Copy Markdown
Member Author

D'oh, I put test -n to test the output message and forgot to replace it with test -z.

tiran marked this pull request as ready for review November 6, 2021 19:01
tiran force-pushed the bpo-45723-pkgconf branch from 8c59d49 to 3061c4b Compare November 7, 2021 09:36
tiran changed the title bpo-45723: Detect missing pkg-config bpo-45723: Detect missing pkg-config (GH-29442) Nov 7, 2021
tiran merged commit be3cd5c into python:main Nov 7, 2021
tiran deleted the bpo-45723-pkgconf branch November 7, 2021 10:18
remykarem pushed a commit to remykarem/cpython that referenced this pull request Dec 7, 2021
bpo-45723: Detect missing pkg-config (pythonGH-29442)
3c415d9
remykarem pushed a commit to remykarem/cpython that referenced this pull request Jan 30, 2022
bpo-45723: Detect missing pkg-config (pythonGH-29442)
1b288cb
tiran mentioned this pull request Apr 22, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

pablogsal pablogsal left review comments
ned-deily ned-deily approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL