FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-45723: Remove dead code for obsolete `--with-dyld` option by erlend-aasland · Pull Request #29500 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

bpo-45723: Remove dead code for obsolete --with-dyld option - #29500

Merged
miss-islington merged 2 commits into
python:mainfrom
erlend-aasland:ac-remove-dead-code
Nov 9, 2021
ConversationCommits (2)ChecksFiles changed
Merged

bpo-45723: Remove dead code for obsolete --with-dyld option#29500
miss-islington merged 2 commits into
python:mainfrom
erlend-aasland:ac-remove-dead-code

Conversation

erlend-aasland commented Nov 9, 2021 •
edited by miss-islington
Loading

Copy link
Copy Markdown
Contributor

Was commented out by Jack Jansen in 2001-08-15 by commit
b6e9cad:

"Ripped out Next/OpenStep support, which was broken anyway"

https://bugs.python.org/issue45723

Automerge-Triggered-By: GH:tiran

bpo-45723: Remove dead code for obsolete --with-dyld option
b62f459 
Was commented out by Jack Jansen in 2001-08-15 by commit
b6e9cad:

"Ripped out Next/OpenStep support, which was broken anyway"
erlend-aasland requested a review from tiran November 9, 2021 19:34
tiran approved these changes Nov 9, 2021
View reviewed changes

tiran left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

👍

tiran requested changes Nov 9, 2021
View reviewed changes

tiran left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

You need to regenerate configure, too.

bedevere-bot commented Nov 9, 2021

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

erlend-aasland requested a review from tiran November 9, 2021 20:42

erlend-aasland commented Nov 9, 2021

Copy link
Copy Markdown
Contributor Author

You need to regenerate configure, too.

Hm, we could add a configure/configure.ac check to the Check if generated files are up to date CI.

tiran commented Nov 9, 2021

Copy link
Copy Markdown
Member

You need to regenerate configure, too.

Hm, we could add a configure/configure.ac check to the Check if generated files are up to date CI.

First I like to move my repo to python org and figure out hosting on ghcr.io.

miss-islington commented Nov 9, 2021

Copy link
Copy Markdown
Contributor

@erlend-aasland: Status check is done, and it's a success ✅ .

miss-islington merged commit 49171aa into python:main Nov 9, 2021
erlend-aasland deleted the ac-remove-dead-code branch November 9, 2021 21:06
thatbirdguythatuknownot added a commit to thatbirdguythatuknownot/cpython that referenced this pull request Nov 9, 2021
bpo-45723: Remove dead code for obsolete --with-dyld option (python…
be6e319 
…GH-29500)
thatbirdguythatuknownot added a commit to thatbirdguythatuknownot/cpython that referenced this pull request Nov 9, 2021
bpo-45723: Remove dead code for obsolete --with-dyld option (python…
30388b9 
…GH-29500)
thatbirdguythatuknownot added a commit to thatbirdguythatuknownot/cpython that referenced this pull request Nov 9, 2021
bpo-45723: Remove dead code for obsolete --with-dyld option (python…
e937253 
…GH-29500)
thatbirdguythatuknownot added a commit to thatbirdguythatuknownot/cpython that referenced this pull request Nov 9, 2021
bpo-45723: Remove dead code for obsolete --with-dyld option (python…
86e565a 
…GH-29500)
remykarem pushed a commit to remykarem/cpython that referenced this pull request Dec 7, 2021
bpo-45723: Remove dead code for obsolete --with-dyld option (python…
f892757 
…GH-29500)

Was commented out by Jack Jansen in 2001-08-15 by commit
b6e9cad:

"Ripped out Next/OpenStep support, which was broken anyway"

Automerge-Triggered-By: GH:tiran
remykarem pushed a commit to remykarem/cpython that referenced this pull request Jan 30, 2022
bpo-45723: Remove dead code for obsolete --with-dyld option (python…
ba54db9 
…GH-29500)

Was commented out by Jack Jansen in 2001-08-15 by commit
b6e9cad:

"Ripped out Next/OpenStep support, which was broken anyway"

Automerge-Triggered-By: GH:tiran
tiran mentioned this pull request Apr 22, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

tiran tiran approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL