FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-45723: Add --with-pkg-config to configure (GH-29517) by tiran · Pull Request #29517 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

bpo-45723: Add --with-pkg-config to configure (GH-29517) - #29517

Merged
tiran merged 2 commits into
python:mainfrom
tiran:bpo-45723-with-pkg-config
Nov 10, 2021
ConversationCommits (2)ChecksFiles changed
Merged

bpo-45723: Add --with-pkg-config to configure (GH-29517)#29517
tiran merged 2 commits into
python:mainfrom
tiran:bpo-45723-with-pkg-config

Conversation

tiran commented Nov 10, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

Let users require or ignore pkg-config. --with-pkg-config makes
pkg-config mandatory. --without-pkg-config disables use of
pkg-config. Disabling is also useful to check how configure behaves
without pkg-config installed.

Signed-off-by: Christian Heimes christian@python.org

https://bugs.python.org/issue45723

tiran requested a review from erlend-aasland November 10, 2021 15:06
tiran force-pushed the bpo-45723-with-pkg-config branch 2 times, most recently from e6a5f7e to d0e72b7 Compare November 10, 2021 15:22
bpo-45723: Add --with-pkg-config to configure
f1bd071 
Let users require or ignore pkg-config. ``--with-pkg-config`` makes
pkg-config mandatory. ``--without-pkg-config`` disables use of
pkg-config. Disabling is also useful to check how configure behaves
without pkg-config installed.

Signed-off-by: Christian Heimes <christian@python.org>
tiran force-pushed the bpo-45723-with-pkg-config branch from d0e72b7 to f1bd071 Compare November 10, 2021 15:32
tiran marked this pull request as ready for review November 10, 2021 15:33
erlend-aasland requested changes Nov 10, 2021
View reviewed changes

erlend-aasland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good. I think a note in Build Changes in What's New would be nice.

Comment thread configure.ac Outdated
Comment thread configure.ac
Comment on lines +167 to +172
if test -z "$PKG_CONFIG"; then
dnl invalidate stale config.cache values
AS_UNSET([PKG_CONFIG])
AS_UNSET([ac_cv_path_ac_pt_PKG_CONFIG])
AS_UNSET([ac_cv_prog_ac_ct_PKG_CONFIG])
fi

erlend-aasland Nov 10, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Unsetting PKG_CONFIG and friends if PKG_CONFIG is not set? Is there a missing ! in the test? Is this check needed at all; the config.cache guard is pretty strict.

tiran Nov 10, 2021

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

It's un-declaring the variables when it's empty. This solves a corner case when going from ./configure -C --without-pkg-config to ./configure -C --with-pkg-config=yes.

tiran Nov 10, 2021

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Maybe you are able to find a better way...

erlend-aasland Nov 10, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I see. No, this is fine. I can't think of a better way.

erlend-aasland commented Nov 10, 2021

Copy link
Copy Markdown
Contributor

Is it worth it listing the packages we actually use pkg-config to detect?

Update configure.ac
1ac540d 
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>

tiran commented Nov 10, 2021

Copy link
Copy Markdown
Member Author

Is it worth it listing the packages we actually use pkg-config to detect?

The pkg-config m4 macro will do that for us.

tiran changed the title bpo-45723: Add --with-pkg-config to configure bpo-45723: Add --with-pkg-config to configure (GH-29517) Nov 10, 2021
tiran merged commit fc9b622 into python:main Nov 10, 2021
tiran deleted the bpo-45723-with-pkg-config branch November 10, 2021 22:02
remykarem pushed a commit to remykarem/cpython that referenced this pull request Dec 7, 2021
bpo-45723: Add --with-pkg-config to configure (pythonGH-29517)
335d864 
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
remykarem pushed a commit to remykarem/cpython that referenced this pull request Jan 30, 2022
bpo-45723: Add --with-pkg-config to configure (pythonGH-29517)
aebafa7 
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
tiran mentioned this pull request Apr 22, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

erlend-aasland erlend-aasland approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL