FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-45711: assert that the type of exc_info is redundant by iritkatriel · Pull Request #29518 · python/cpython · GitHub

/ cpython Public

bpo-45711: assert that the type of exc_info is redundant - #29518

Merged
iritkatriel merged 2 commits into
python:mainfrom
iritkatriel:bpo-45711-exc_info_type_redundant
Nov 12, 2021
ConversationCommits (2)ChecksFiles changed
Merged

bpo-45711: assert that the type of exc_info is redundant#29518
iritkatriel merged 2 commits into
python:mainfrom
iritkatriel:bpo-45711-exc_info_type_redundant

Conversation

iritkatriel commented Nov 10, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

I suggest we commit this so that the diff when we remove the type shows why we think it's safe to do so.

https://bugs.python.org/issue45711

bedevere-bot commented Nov 10, 2021

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit d7c8d15 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

iritkatriel added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 10, 2021
bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 10, 2021

iritkatriel commented Nov 11, 2021

Copy link
Copy Markdown
Member Author

The test_gdb failure is happening on other branches as well, so this is looking good. Let me know if you think there is value in committing this (I thinking if something breaks in the future, after we remove the type, it might help to have this commit in the history).

gvanrossum commented Nov 11, 2021

Copy link
Copy Markdown
Member

I worry that the code won't be completely removed even by PGO/LTO. Or am I too fearful?

iritkatriel commented Nov 11, 2021

Copy link
Copy Markdown
Member Author

Right, I can make it a macro working in debug mode only.

iritkatriel mentioned this pull request Nov 12, 2021
Closed

markshannon commented Nov 12, 2021

Copy link
Copy Markdown
Member

Looks good 👍

iritkatriel merged commit de3db14 into python:main Nov 12, 2021
remykarem pushed a commit to remykarem/cpython that referenced this pull request Dec 7, 2021
bpo-45711: assert that the type of exc_info is redundant (pythonGH-29518
ce9802a 
)
iritkatriel deleted the bpo-45711-exc_info_type_redundant branch January 13, 2022 15:35
remykarem pushed a commit to remykarem/cpython that referenced this pull request Jan 30, 2022
bpo-45711: assert that the type of exc_info is redundant (pythonGH-29518
8fd8781 
)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

gvanrossum gvanrossum approved these changes
markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL