bpo-45847: Port _scproxy to PY_STDLIB_MOD (GH-29644) - #29644
Merged
tiran merged 1 commit intoNov 20, 2021
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
On macOS, the Makefile should contain: MODULE__SCPROXY=yes MODULE__SCPROXY_CFLAGS= MODULE__SCPROXY_LDFLAGS=-framework SystemConfiguration -framework CoreFoundation and setup.py should pick up the settings automatically. |
Sorry, something went wrong.
ned-deily
approved these changes
Nov 19, 2021
ned-deily
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
tiran
marked this pull request as ready for review
November 20, 2021 09:18
remykarem
pushed a commit
to remykarem/cpython
that referenced
this pull request
Dec 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue45847