FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

GH-89769: Pathlib - do not follow links when checking for precise glob match by akulakov · Pull Request #29655 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

GH-89769: Pathlib - do not follow links when checking for precise glob match - #29655

Merged
barneygale merged 15 commits into
python:mainfrom
akulakov:45606-Path-glob-no-follow-symlink
May 3, 2023
ConversationCommits (15)ChecksFiles changed
Merged

GH-89769: Pathlib - do not follow links when checking for precise glob match#29655
barneygale merged 15 commits into
python:mainfrom
akulakov:45606-Path-glob-no-follow-symlink

Conversation

akulakov commented Nov 20, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

https://bugs.python.org/issue45606

I've also added a follow_symlinks arg to exists() method because it seems more logical to be able to test if a path exists via the same method rather than having to also remember and to check for it being a symlink. This is also consistent with a few other Path methods; and it makes it more explicit and clearer that by default exists() follows symlinks, by looking at its signature (otherwise this may be a surprising behaviour).

ambv reviewed Nov 20, 2021
View reviewed changes
Comment thread Lib/test/test_pathlib.py Outdated

github-actions Bot commented Dec 21, 2021

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

github-actions Bot added the stale Stale PR or inactive for long period of time. label Dec 21, 2021
MaxwellDupre approved these changes Mar 1, 2022
View reviewed changes

MaxwellDupre left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Works on my Ubuntu and I see bot tests are ok, so ok with me.

raek mannequin mentioned this pull request Apr 10, 2022
Closed
barneygale requested changes May 2, 2023
View reviewed changes

barneygale left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Change looks good! Could you fix conflicts please?

Comment thread Doc/library/pathlib.rst Outdated
Comment thread Lib/pathlib.py Outdated
Comment thread Lib/pathlib.py Outdated
Comment thread Lib/pathlib.py Outdated
Comment thread Misc/NEWS.d/next/Library/2021-11-19-23-37-18.bpo-45606.UW5XE1.rst Outdated

bedevere-bot commented May 2, 2023

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

barneygale changed the title bpo-45606: Pathlib - do not follow links when checking for precise glob match GH-89769: Pathlib - do not follow links when checking for precise glob match May 2, 2023
akulakov and others added 5 commits May 2, 2023 21:53
Update Lib/pathlib.py
66700bf 
Co-authored-by: Barney Gale <barney.gale@gmail.com>
Update Doc/library/pathlib.rst
0e07f88 
Co-authored-by: Barney Gale <barney.gale@gmail.com>
Update Lib/pathlib.py
071f0f3 
Co-authored-by: Barney Gale <barney.gale@gmail.com>
Update Misc/NEWS.d/next/Library/2021-11-19-23-37-18.bpo-45606.UW5XE1.rst
6cff634 
Co-authored-by: Barney Gale <barney.gale@gmail.com>
update docstring
3818c31
barneygale approved these changes May 3, 2023
View reviewed changes

barneygale left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Last nit. Thanks!

Comment thread Doc/library/pathlib.rst Outdated
barneygale removed the stale Stale PR or inactive for long period of time. label May 3, 2023
barneygale merged commit af886ff into python:main May 3, 2023

barneygale commented May 3, 2023

Copy link
Copy Markdown
Contributor

Thanks again, @akulakov

akulakov commented May 3, 2023

Copy link
Copy Markdown
Contributor Author

Thanks @barneygale for the review and merging!

erlend-aasland mentioned this pull request May 3, 2023
Merged
barneygale mentioned this pull request Jun 14, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ambv ambv left review comments
barneygale barneygale approved these changes
+1 more reviewer
MaxwellDupre MaxwellDupre approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

topic-pathlib

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL