FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-45847: Port nis module to PY_STDLIB_MOD (GH-29699) by tiran · Pull Request #29699 · python/cpython · GitHub

/ cpython Public

bpo-45847: Port nis module to PY_STDLIB_MOD (GH-29699) - #29699

Merged
tiran merged 2 commits into
python:mainfrom
tiran:bpo-45847-nis
Nov 22, 2021
Merged

bpo-45847: Port nis module to PY_STDLIB_MOD (GH-29699)#29699
tiran merged 2 commits into
python:mainfrom
tiran:bpo-45847-nis

Conversation

tiran commented Nov 22, 2021
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

tiran marked this pull request as ready for review November 22, 2021 11:17
tiran added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 22, 2021

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @tiran for commit 3043b762c9cbcb0500de5d9e19cb4139e1457d40 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 22, 2021
tiran changed the title bpo-45847: Port nis module to PY_STDLIB_MOD_SIMPLE bpo-45847: Port nis module to PY_STDLIB_MOD Nov 22, 2021
Comment thread configure.ac Outdated
tiran added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 22, 2021

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @tiran for commit c6c687160b4ad830a55235581e6515f36ffe27cd 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 22, 2021
tiran requested a review from erlend-aasland November 22, 2021 13:29
Signed-off-by: Christian Heimes <christian@python.org>
Comment thread Modules/Setup.stdlib.in
@MODULE__RANDOM_TRUE@_random _randommodule.c
@MODULE__TYPING_TRUE@_typing _typingmodule.c
@MODULE__XXSUBINTERPRETERS_TRUE@_xxsubinterpreters __xxsubinterpretersmodule.c
@MODULE__XXSUBINTERPRETERS_TRUE@_xxsubinterpreters _xxsubinterpretersmodule.c

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@erlend-aasland I'm sneaking in this typo fix, too.

Comment thread configure.ac

PY_STDLIB_MOD([_decimal], [], [], [$LIBMPDEC_CFLAGS], [$LIBMPDEC_LDFLAGS])
PY_STDLIB_MOD([nis],
[], [test "$have_nis" = yes -a "$ac_cv_header_rpc_rpc_h" = yes],

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

AFAICS, header check for rpc/rpc.h is missing.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

It's right there:

AS_VAR_IF([have_nis], [yes], [
  WITH_SAVE_ENV([
    CPPFLAGS="$LIBNSL_CFLAGS $CFLAGS"
    AC_CHECK_HEADERS([rpc/rpc.h])
  ])
])

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

🤦🏻

tiran changed the title bpo-45847: Port nis module to PY_STDLIB_MOD bpo-45847: Port nis module to PY_STDLIB_MOD (GH-29699) Nov 22, 2021
tiran merged commit c6dec7e into python:main Nov 22, 2021
tiran deleted the bpo-45847-nis branch November 22, 2021 14:18
remykarem pushed a commit to remykarem/cpython that referenced this pull request Dec 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL