FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-45847: Port _gdbm to PY_STDLIB_MOD (GH-29720) by tiran · Pull Request #29720 · python/cpython · GitHub

/ cpython Public

bpo-45847: Port _gdbm to PY_STDLIB_MOD (GH-29720) - #29720

Merged
tiran merged 1 commit into
python:mainfrom
tiran:bpo-45847-gdbm
Nov 23, 2021
ConversationCommits (1)ChecksFiles changed
Merged

bpo-45847: Port _gdbm to PY_STDLIB_MOD (GH-29720)#29720
tiran merged 1 commit into
python:mainfrom
tiran:bpo-45847-gdbm

Conversation

tiran commented Nov 23, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

bpo-45847: Port _gdbm to PY_STDLIB_MOD
f7e0372 
Signed-off-by: Christian Heimes <christian@python.org>
tiran requested a review from erlend-aasland November 23, 2021 10:53
erlend-aasland approved these changes Nov 23, 2021
View reviewed changes
Comment thread configure.ac
[ndbm], [],
[gdbm], [have_gdbm_dbmliborder=yes],
[bdb], [],
[with_dbmliborder=error]

erlend-aasland Nov 23, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'd just put AC_MSG_ERROR here, avoiding the AS_VAR_IF below, but I'm fine with this variant as well.

tiran Nov 23, 2021

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I tried it. For unknown reasons it does not work. I get a bunch of shell error messages when the error case is triggered.

Comment thread configure.ac
Comment on lines +3380 to +3381
as_save_IFS=$IFS
IFS=:

erlend-aasland Nov 23, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

BTW, why do we save IFS here? AFAICS, there's nothing touching it, but I may be mistaken.

tiran Nov 23, 2021

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'm saving and setting IFS here so the for loop uses : as a field separator.

erlend-aasland Nov 23, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Yes, just found it in the man page. Learned something new today.

tiran changed the title bpo-45847: Port _gdbm to PY_STDLIB_MOD bpo-45847: Port _gdbm to PY_STDLIB_MOD (GH-29720) Nov 23, 2021
tiran merged commit 9cf5646 into python:main Nov 23, 2021
tiran deleted the bpo-45847-gdbm branch November 23, 2021 21:58
remykarem pushed a commit to remykarem/cpython that referenced this pull request Dec 7, 2021
bpo-45847: Port _gdbm to PY_STDLIB_MOD (pythonGH-29720)
fdd7f3e
tiran mentioned this pull request Apr 14, 2022
Closed
ambv mentioned this pull request May 3, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

erlend-aasland erlend-aasland approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL