bpo-37705: Remove orphaned PC/errmap.mak - #29724
Merged
miss-islington merged 1 commit intoFeb 2, 2022
Merged
miss-islington merged 1 commit into
miss-islington merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
After pythonGH-15623 deleted `generrmap.c`, a related mak-file stopped working. The mak contains generrmap-related rules only so it should be removed altogether. Further search for `errmap\.mak|generrmap` regex through content of CPython files shows no dangling reference left.
Copy link
Copy Markdown
Member
Author
|
I believe this PR does not require a separate NEWS entry because the removed file was not functional anyway so it has no interested parties. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
To test a recent fix to @miss-islington, @JelleZijlstra will be adding the automerge label shortly. |
Sorry, something went wrong.
zware
approved these changes
Feb 2, 2022
Copy link
Copy Markdown
Member
|
We now have a well-behaved bot :). Thanks @JelleZijlstra! And thanks @arhadthedev for the patch, which I'll now properly merge :) |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After GH-15623 deleted generrmap.c, a related mak-file stopped working. The mak contains generrmap-related rules only so it should be removed altogether.
Further search for errmap\.mak|generrmap regex through content of CPython files shows no dangling reference left.
Since generrmap is already effectively removed, this pull request contains no blurp.
https://bugs.python.org/issue37705
Automerge-Triggered-By: GH:zware