Repository navigation
[WIP] bpo-45490: Convert static inline to macros - #29728
Closed
vstinner wants to merge 1 commit into
Closed
vstinner wants to merge 1 commit into
vstinner wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
PR created to run benchmarks comparing static inline functions and macros for the PEP 670: https://www.python.org/dev/peps/pep-0670/ |
Sorry, something went wrong.
Convert static inline functions to macros to run a benchmark: * PyObject_TypeCheck() * PyType_Check() * PyType_CheckExact() * PyType_HasFeature() * PyVectorcall_NARGS() * Py_DECREF() * Py_INCREF() * Py_IS_TYPE() * Py_NewRef() * Py_REFCNT() * Py_SIZE() * Py_TYPE() * Py_XDECREF() * Py_XINCREF() Note: Py_XNewRef() remains a static inline function.
Copy link
Copy Markdown
Member
Author
|
"Check if generated files are up to date" CI test failed with: Some extra declarations were found in "Include/Python.h" with Py_LIMITED_API: - _PyDebug_PrintTotalRefs |
Sorry, something went wrong.
Copy link
Copy Markdown
|
This PR is stale because it has been open for 30 days with no activity. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert static inline functions to macros to run a benchmark:
Note: Py_XNewRef() remains a static inline function.
https://bugs.python.org/issue45490