bpo-45847: Port _ctypes partly to PY_STDLIB_MOD (GH-29747) - #29747
Merged
tiran merged 3 commits intoDec 4, 2021
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
tiran
force-pushed
the
bpo-45847-ctypes
branch
from
1de4941 to
e39443e
Compare
November 24, 2021 11:43
Copy link
Copy Markdown
|
🤖 New build scheduled with the buildbot fleet by @tiran for commit e39443e8c0770623ca81d8b17ff3317d2010361c 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
@ned-deily @ronaldoussoren I need your help with the macOS part of the patch. setup.py does some macOS specific things that I don't understand. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Which parts do you need help with? It should be possible to move the macOS logic to configure.ac, although I'm a bit hazy at the moment about why some of the logic is there and some of the logic might be broken (in particular the code that sets USING_APPLE_OS_LIBFFI seems dodgy when self.use_system_libffi is false). I can look into this at the end of the week. BTW. Feel free to ping me directly, I don't regularly look at GitHub messages and only noticed your question promptly because Mail.app claimed it was junk mail. |
Sorry, something went wrong.
tiran
force-pushed
the
bpo-45847-ctypes
branch
from
e39443e to
1979b52
Compare
November 28, 2021 12:04
tiran
marked this pull request as ready for review
November 28, 2021 12:07
Comment thread
configure.ac
Outdated
Signed-off-by: Christian Heimes <christian@python.org>
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
tiran
force-pushed
the
bpo-45847-ctypes
branch
from
6c817f1 to
4d74daa
Compare
December 4, 2021 09:37
Copy link
Copy Markdown
Member
|
@tiran After this PR, the gentoo builder is failing: https://buildbot.python.org/all/#/builders/58/builds/1217 test_free_called (test.test_code.CoExtra) ... Fatal Python error: Illegal instruction Current thread 0xb7bd4700 (most recent call first): File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/test/test_code.py", line 575 in test_free_called File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/unittest/case.py", line 547 in _callTestMethod File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/unittest/case.py", line 591 in run File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/unittest/case.py", line 646 in __call__ File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/unittest/suite.py", line 122 in run File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/unittest/suite.py", line 84 in __call__ File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/unittest/suite.py", line 122 in run File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/unittest/suite.py", line 84 in __call__ File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/unittest/suite.py", line 122 in run File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/unittest/suite.py", line 84 in __call__ File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/unittest/runner.py", line 197 in run File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/test/support/__init__.py", line 1009 in _run_suite File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/test/support/__init__.py", line 1135 in run_unittest File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/test/libregrtest/runtest.py", line 273 in _test_module File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/test/libregrtest/runtest.py", line 309 in _runtest_inner2 File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/test/libregrtest/runtest.py", line 352 in _runtest_inner File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/test/libregrtest/runtest.py", line 227 in _runtest File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/test/libregrtest/runtest.py", line 257 in runtest File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/test/libregrtest/main.py", line 337 in rerun_failed_tests File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/test/libregrtest/main.py", line 715 in _main File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/test/libregrtest/main.py", line 658 in main File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/test/libregrtest/main.py", line 736 in main File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/test/__main__.py", line 2 in <module> File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/runpy.py", line 86 in _run_code File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/runpy.py", line 196 in _run_module_as_main |
Sorry, something went wrong.
tiran
added a commit
to tiran/cpython
that referenced
this pull request
Dec 7, 2021
…)" This reverts commit 4045392.
tiran
added a commit
that referenced
this pull request
Dec 7, 2021
tiran
added a commit
to tiran/cpython
that referenced
this pull request
Jun 26, 2022
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Christian Heimes christian@python.org
https://bugs.python.org/issue45847