bpo-45847: Port _multiprocessing to PY_STDLIB_MOD (GH-29768) - #29768
Merged
tiran merged 2 commits intoNov 28, 2021
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
erlend-aasland
force-pushed
the
ac-multiproc
branch
from
3646de5 to
cf31521
Compare
November 25, 2021 00:17
tiran
reviewed
Nov 25, 2021
Comment thread
configure.ac
Outdated
erlend-aasland
force-pushed
the
ac-multiproc
branch
2 times, most recently
from
36cf95f to
91c7cd9
Compare
November 25, 2021 16:40
erlend-aasland
marked this pull request as ready for review
November 25, 2021 16:40
Copy link
Copy Markdown
Contributor
Author
|
AFAICS, HAVE_SEM_OPEN and POSIX_SEMAPHORES_NOT_ENABLED are handled by #ifdefs in the source code. We could add a check for $ac_cv_header_fcntl_h, but it's probably not needed. |
Sorry, something went wrong.
erlend-aasland
force-pushed
the
ac-multiproc
branch
from
91c7cd9 to
0af5f50
Compare
November 25, 2021 16:44
tiran
approved these changes
Nov 26, 2021
tiran
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks, looks good to me.
I'm unsure about the semaphore extension. It is hard to test.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
Me too. Let's ask on python-dev / Discourse. |
Sorry, something went wrong.
erlend-aasland
marked this pull request as draft
November 27, 2021 19:31
erlend-aasland
marked this pull request as ready for review
November 27, 2021 19:41
tiran
approved these changes
Nov 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue45847