FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-41498: Fix build on platforms without sigset_t (GH-29770) by tiran · Pull Request #29770 · python/cpython · GitHub

/ cpython Public

bpo-41498: Fix build on platforms without sigset_t (GH-29770) - #29770

Merged
tiran merged 1 commit into
python:mainfrom
tiran:bpo-41498-sigset_t
Nov 25, 2021
ConversationCommits (1)ChecksFiles changed
Merged

bpo-41498: Fix build on platforms without sigset_t (GH-29770)#29770
tiran merged 1 commit into
python:mainfrom
tiran:bpo-41498-sigset_t

Conversation

tiran commented Nov 25, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

Python now compiles on platforms without sigset_t. Several functions
in :mod:signal are not available when sigset_t is missing.

Based on patch by Roman Yurchak for pyodide.

Signed-off-by: Christian Heimes christian@python.org

https://bugs.python.org/issue41498

bpo-41498: Fix build on platforms without sigset_t
691eef3 
Python now compiles on platforms without ``sigset_t``. Several functions
in :mod:`signal` are not available when ``sigset_t`` is missing.

Based on patch by Roman Yurchak for pyodide.

Signed-off-by: Christian Heimes <christian@python.org>
tiran force-pushed the bpo-41498-sigset_t branch from 86474f4 to 691eef3 Compare November 25, 2021 10:25

pablogsal commented Nov 25, 2021

Copy link
Copy Markdown
Member

It would be good to have a buildbot validating these but is simple enough to go ahead

tiran commented Nov 25, 2021

Copy link
Copy Markdown
Member Author

It would be good to have a buildbot validating these but is simple enough to go ahead

We'll get some smoke tests for the problem when we have wasm builds.

tiran changed the title bpo-41498: Fix build on platforms without sigset_t bpo-41498: Fix build on platforms without sigset_t (GH-29770) Nov 25, 2021
tiran merged commit dc19e86 into python:main Nov 25, 2021
tiran deleted the bpo-41498-sigset_t branch November 25, 2021 11:28

miss-islington commented Nov 25, 2021

Copy link
Copy Markdown
Contributor

Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

miss-islington commented Nov 25, 2021

Copy link
Copy Markdown
Contributor

Sorry, @tiran, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker dc19e8698327cae3d6274b73c135375955f1d0d0 3.9

bedevere-bot removed the needs backport to 3.10 only security fixes label Nov 25, 2021

bedevere-bot commented Nov 25, 2021

Copy link
Copy Markdown

GH-29773 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 25, 2021
bpo-41498: Fix build on platforms without sigset_t (pythonGH-29770)
e902894 
(cherry picked from commit dc19e86)

Co-authored-by: Christian Heimes <christian@python.org>
tiran added a commit to tiran/cpython that referenced this pull request Nov 25, 2021
[3.9] bpo-41498: Fix build on platforms without sigset_t (pythonGH-29770
bd7e38f 
).

(cherry picked from commit dc19e86)

Co-authored-by: Christian Heimes <christian@python.org>

bedevere-bot commented Nov 25, 2021

Copy link
Copy Markdown

GH-29774 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit that referenced this pull request Nov 25, 2021
[3.10] bpo-41498: Fix build on platforms without sigset_t (GH-29770) (G…
632d589 
…H-29773)

(cherry picked from commit dc19e86)


Co-authored-by: Christian Heimes <christian@python.org>

Automerge-Triggered-By: GH:tiran
tiran added a commit that referenced this pull request Nov 25, 2021
[3.9] bpo-41498: Fix build on platforms without sigset_t (GH-29770) (G…
71b4147 
…H-29774)

Co-authored-by: Christian Heimes <christian@python.org>
tiran mentioned this pull request Nov 25, 2021
Merged
remykarem pushed a commit to remykarem/cpython that referenced this pull request Dec 7, 2021
bpo-41498: Fix build on platforms without sigset_t (pythonGH-29770)
f5b277c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

pablogsal pablogsal approved these changes

Assignees

tiran

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL