bpo-45881: configure --with-freeze-module --with-build-python (GH-29835) - #29835
Merged
tiran merged 7 commits intoNov 29, 2021
Merged
bpo-45881: configure --with-freeze-module --with-build-python (GH-29835)#29835tiran merged 7 commits into
tiran merged 7 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
This changeset makes our configure call easier: emconfigure ../../configure -C --with-freeze-module=$(pwd)/../build/Programs/_freeze_module --with-build-python=$(pwd)/../build/python
|
Sorry, something went wrong.
erlend-aasland
approved these changes
Nov 29, 2021
Comment thread
configure.ac
Outdated
emmatyping
reviewed
Nov 29, 2021
emmatyping
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
I have a bunch of minor nits but overall this looks good! I also think we should be strict in checking that the Python version used for _freeze_module is the same as the host Python.
Sorry, something went wrong.
Comment thread
configure.ac
Outdated
Comment thread
configure.ac
Outdated
Comment thread
configure.ac
Outdated
Comment thread
configure.ac
Outdated
Comment thread
configure.ac
Outdated
Comment thread
configure.ac
Outdated
Comment thread
configure.ac
Outdated
tiran
force-pushed
the
bpo-45881-cross-freeze
branch
from
772abec to
7fbc2b4
Compare
November 29, 2021 15:30
tiran
marked this pull request as ready for review
November 29, 2021 15:31
Make cross compiling more convenient. configure now takes ``--with-freeze-module`` and ``--with-build-python`` arguments. There is no need pass ``FREEZE_MODULE`` and ``PYTHON_FOR_BUILD`` env vars any more. Signed-off-by: Christian Heimes <christian@python.org>
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
Co-authored-by: Ethan Smith <ethan@ethanhs.me>
Co-authored-by: Ethan Smith <ethan@ethanhs.me>
Co-authored-by: Ethan Smith <ethan@ethanhs.me>
tiran
force-pushed
the
bpo-45881-cross-freeze
branch
from
158a573 to
e4eff12
Compare
November 29, 2021 15:34
emmatyping
approved these changes
Nov 29, 2021
tiran
added a commit
to tiran/python-wasm
that referenced
this pull request
Nov 29, 2021
See: python/cpython#29835 Signed-off-by: Christian Heimes <christian@python.org>
shihai1991
added a commit
to shihai1991/cpython
that referenced
this pull request
Dec 1, 2021
* main: (21 commits) bpo-45876: Have stdev() also use decimal specific square root. (pythonGH-29869) bpo-45876: Correctly rounded stdev() and pstdev() for the Decimal case (pythonGH-29828) bpo-45711: Change exc_info related APIs to derive type and traceback from the exception instance (pythonGH-29780) bpo-30533:Add function inspect.getmembers_static that does not call properties or dynamic properties. (python#20911) bpo-45476: Disallow using asdl_seq_GET() as l-value (pythonGH-29866) bpo-45476: Add _Py_RVALUE() macro (pythonGH-29860) bpo-33381: [doc] strftime's %f option may pad zeros on the left or the right (pythonGH-29801) Fix EncodingWarning in Tools/freeze/test/freeze.py (pythonGH-29742) no-issue: remove unused import from test_graphlib.py (pythonGH-29853) bpo-45931: Prevent Directory.Build.props/targets from leaking from directories above the repo when building on Windows (pythonGH-29854) bpo-45653: fix test_embed on windows (pythonGH-29814) bpo-45917: Add math.exp2() method - return 2 raised to the power of x (pythonGH-29829) bpo-43905: Expand dataclasses.astuple() and asdict() docs (pythonGH-26154) bpo-44391: Remove unused argument from a varargs call. (pythonGH-29843) bpo-45881: configure --with-freeze-module --with-build-python (pythonGH-29835) bpo-45847: PY_STDLIB_MOD_SIMPLE now checks py_stdlib_not_available (pythonGH-29844) bpo-45828: Use unraisable exceptions within sqlite3 callbacks (FH-29591) bpo-40280: Emscripten systems use .wasm suffix by default (pythonGH-29842) bpo-45723: Sort the grand AC_CHECK_HEADERS check (pythonGH-29846) bpo-45847: Make socket module conditional (pythonGH-29769) ...
shihai1991
added a commit
to shihai1991/cpython
that referenced
this pull request
Dec 1, 2021
* main: (21 commits) bpo-45876: Have stdev() also use decimal specific square root. (pythonGH-29869) bpo-45876: Correctly rounded stdev() and pstdev() for the Decimal case (pythonGH-29828) bpo-45711: Change exc_info related APIs to derive type and traceback from the exception instance (pythonGH-29780) bpo-30533:Add function inspect.getmembers_static that does not call properties or dynamic properties. (python#20911) bpo-45476: Disallow using asdl_seq_GET() as l-value (pythonGH-29866) bpo-45476: Add _Py_RVALUE() macro (pythonGH-29860) bpo-33381: [doc] strftime's %f option may pad zeros on the left or the right (pythonGH-29801) Fix EncodingWarning in Tools/freeze/test/freeze.py (pythonGH-29742) no-issue: remove unused import from test_graphlib.py (pythonGH-29853) bpo-45931: Prevent Directory.Build.props/targets from leaking from directories above the repo when building on Windows (pythonGH-29854) bpo-45653: fix test_embed on windows (pythonGH-29814) bpo-45917: Add math.exp2() method - return 2 raised to the power of x (pythonGH-29829) bpo-43905: Expand dataclasses.astuple() and asdict() docs (pythonGH-26154) bpo-44391: Remove unused argument from a varargs call. (pythonGH-29843) bpo-45881: configure --with-freeze-module --with-build-python (pythonGH-29835) bpo-45847: PY_STDLIB_MOD_SIMPLE now checks py_stdlib_not_available (pythonGH-29844) bpo-45828: Use unraisable exceptions within sqlite3 callbacks (FH-29591) bpo-40280: Emscripten systems use .wasm suffix by default (pythonGH-29842) bpo-45723: Sort the grand AC_CHECK_HEADERS check (pythonGH-29846) bpo-45847: Make socket module conditional (pythonGH-29769) ...
This was referenced Apr 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make cross compiling more convenient. configure now takes
--with-freeze-module and --with-build-python arguments. There is
no need pass FREEZE_MODULE and PYTHON_FOR_BUILD env vars any
more.
Signed-off-by: Christian Heimes christian@python.org
https://bugs.python.org/issue45881