bpo-40280: Emscripten defaults to --with-ensurepip=no (GH-29873) - #29873
Merged
tiran merged 1 commit intoDec 1, 2021
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Reduces installation size of browser bundle Signed-off-by: Christian Heimes <christian@python.org>
tiran
force-pushed
the
bpo-40280-ensurepip
branch
from
9678387 to
4f8cc1a
Compare
December 1, 2021 08:11
emmatyping
reviewed
Dec 1, 2021
Comment thread
configure.ac
| [with_ensurepip=upgrade]) | ||
| [ | ||
| AS_CASE([$ac_sys_system], | ||
| [Emscripten], [$with_ensurepip=no], |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Should we disable ensurepip for WASI as well?
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
I prefer to wait until we have WASI builds working and more experience with WASI.
Sorry, something went wrong.
brettcannon
approved these changes
Dec 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduces installation size of browser bundle
https://bugs.python.org/issue40280