bpo-45711: Remove unnecessary normalization of exc_info - #29922
Merged
iritkatriel merged 3 commits intoDec 8, 2021
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
arhadthedev
reviewed
Dec 5, 2021
Comment thread
Misc/NEWS.d/next/Core and Builtins/2021-12-05-17-36-08.bpo-45711.3TmTSw.rst
Outdated
Co-authored-by: Oleg Iarygin <dralife@yandex.ru>
gvanrossum
approved these changes
Dec 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
exc_info should always be normalized, so it is not necessary to normalize it here.
It is also not necessary to copy the traceback to the exception instance. I added an assertion that the traceback does not change, and it broke only one test: test_exception_chaining_after_await_with_context_cycle
This is a test that raises the same exception twice, and makes sure that no context cycle is created. The test is not concerned with the traceback at all. We discussed the issue of the traceback change in this test in PR29780.
https://bugs.python.org/issue45711