bpo-45582: Fix getpath_isxfile() and test_embed on Windows - #29930
Merged
zooba merged 2 commits intoDec 6, 2021
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
zooba
approved these changes
Dec 6, 2021
Copy link
Copy Markdown
Contributor
Author
|
Thanks. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current getpath_isxfile() in getpath.c always returns false.
After the function is fixed, test_embed.py needs a workaround to pass the following tests that have the same error in the release build.
FAIL: test_init_pybuilddir_win32 (test.test_embed.InitConfigTests) ---------------------------------------------------------------------- Traceback (most recent call last): File "C:\cp\Lib\test\test_embed.py", line 1322, in test_init_pybuilddir_win32 self.check_all_configs("test_init_compat_config", config, ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "C:\cp\Lib\test\test_embed.py", line 728, in check_all_configs self.check_config(configs, expected_config) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "C:\cp\Lib\test\test_embed.py", line 654, in check_config self.assertEqual(config, expected) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ AssertionError: {'_co[316 chars]embed.exe', ... ... - 'program_name': './_testembed.exe', ? ---- + 'program_name': './_testembed', ...The debug build passes them using the default program_name, and the PGO build does not due to another issue.
https://bugs.python.org/issue45582