Repository navigation
bpo-45950: Fix macOS framework builds of _bootstrap_python (GH-29936) - #29936
Merged
tiran merged 2 commits intoDec 6, 2021
Merged
tiran merged 2 commits into
tiran merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
|
🤖 New build scheduled with the buildbot fleet by @tiran for commit 02dc19dd98f2eaa19c2de25eb5a48dec857fa7b1 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
Sorry, something went wrong.
tiran
force-pushed
the
bpo-45950-macos
branch
from
02dc19d to
cb45323
Compare
December 6, 2021 13:05
tiran
force-pushed
the
bpo-45950-macos
branch
from
cb45323 to
0a3a53c
Compare
December 6, 2021 13:35
tiran
marked this pull request as ready for review
December 6, 2021 14:19
ambv
approved these changes
Dec 6, 2021
gvanrossum
reviewed
Dec 7, 2021
Comment thread
Makefile.pre.in
Comment on lines
+1208
to
+1217
| # like getpath.o with additional -DPY_BOOTSTRAP_PYTHON=1 | ||
| Modules/getpath_bootstrap.o: $(srcdir)/Modules/getpath.c Python/frozen_modules/getpath.h Makefile $(PYTHON_HEADERS) | ||
| $(CC) -c $(PY_CORE_CFLAGS) -DPYTHONPATH='"$(PYTHONPATH)"' \ | ||
| -DPREFIX='"$(prefix)"' \ | ||
| -DEXEC_PREFIX='"$(exec_prefix)"' \ | ||
| -DVERSION='"$(VERSION)"' \ | ||
| -DVPATH='"$(VPATH)"' \ | ||
| -DPLATLIBDIR='"$(PLATLIBDIR)"' \ | ||
| -DPY_BOOTSTRAP_PYTHON=1 \ | ||
| -o $@ $(srcdir)/Modules/getpath.c |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Wouldn't it be more elegant to have a two-line file named getpath_bootstrap.c using the default .c.o rule?
#define BOOTSTRAP_PYTHON 1
#include "getpath.c"
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
I agree that the approach is not elegant. getpath.c requires additional macros
Lines 24 to 28 in ddbab69
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…g framework
https://bugs.python.org/issue45950