FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-45711: Do not push/pop traceback on stack as part of exc_info by iritkatriel · Pull Request #29968 · python/cpython · GitHub

/ cpython Public

bpo-45711: Do not push/pop traceback on stack as part of exc_info - #29968

Closed
iritkatriel wants to merge 5 commits into
python:mainfrom
iritkatriel:45711-no-traceback-in-stack
ConversationCommits (5)ChecksFiles changed
Closed

bpo-45711: Do not push/pop traceback on stack as part of exc_info#29968
iritkatriel wants to merge 5 commits into
python:mainfrom
iritkatriel:45711-no-traceback-in-stack

Conversation

iritkatriel commented Dec 7, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

iritkatriel marked this pull request as draft December 7, 2021 17:47

iritkatriel commented Dec 7, 2021

Copy link
Copy Markdown
Member Author

Marked as draft because I still need to update the opcodes documentation

iritkatriel commented Dec 7, 2021
View reviewed changes
Comment thread Python/ceval.c

assert(exc_info->exc_value);
if (exc_info->exc_value != Py_None) {
exc_info->exc_traceback = PyException_GetTraceback(exc_info->exc_value);

iritkatriel Dec 7, 2021

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The next step is to remove exc_traceback from exc_info and then this will not be here.

iritkatriel added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Dec 7, 2021

bedevere-bot commented Dec 7, 2021

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit 98085fe 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Dec 7, 2021
iritkatriel marked this pull request as ready for review December 7, 2021 18:15

iritkatriel commented Dec 7, 2021

Copy link
Copy Markdown
Member Author

This clashes with the except* branch, and I'd rather merge that one first and update this one.

markshannon commented Dec 8, 2021

Copy link
Copy Markdown
Member

This clashes with the except* branch, and I'd rather merge that one first and update this one.

I would rather merge this first.
Apart from the trivial conflict in dis.rst this seems ready to merge. The except* branch is not.

iritkatriel commented Dec 8, 2021

Copy link
Copy Markdown
Member Author

This clashes with the except* branch, and I'd rather merge that one first and update this one.

I would rather merge this first. Apart from the trivial conflict in dis.rst this seems ready to merge. The except* branch is not.

We won't see a speedup for this because of the get_exc_traceback calls. We should remove them before measuring, and probably merge the whole thing together.

iritkatriel commented Dec 8, 2021

Copy link
Copy Markdown
Member Author

We won't see a speedup for this because of the get_exc_traceback calls. We should remove them before measuring, and probably merge the whole thing together.

And that requires PR 29922.

arhadthedev requested changes Dec 8, 2021
View reviewed changes

arhadthedev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Spacing between tokens is strange.

Comment thread Python/compile.c Outdated
Comment thread Python/ceval.c Outdated
Comment thread Python/ceval.c Outdated

iritkatriel commented Dec 15, 2021

Copy link
Copy Markdown
Member Author

Superseded by #30122

iritkatriel deleted the 45711-no-traceback-in-stack branch January 13, 2022 15:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

arhadthedev arhadthedev requested changes
markshannon Awaiting requested review from markshannon markshannon is a code owner
gvanrossum Awaiting requested review from gvanrossum

Assignees

No one assigned

Labels

awaiting core review DO-NOT-MERGE

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL