Repository navigation
bpo-45582: Fix test_embed failure during a PGO build on Windows - #30014
Merged
zooba merged 12 commits intoDec 10, 2021
Merged
zooba merged 12 commits into
zooba merged 12 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
I like this change better, but maybe we should get VPATH into sysconfig so that it can be used in the test? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
I think adding it as sys._vpath but only on Windows is fine for this. Then sysconfig can add it into its dict if it's there. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Thank you for the nice idea. I've finished the implementation. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PGO-instrumented _testembed.exe and getpath.py often miscalculate the prefix path, when launched with all PYTHON* envvars removed.
The new path calculation uses VPATH, which is defined as "..\\.." in pythoncore.vcxproj. From PGO-instrumented folder, VPATH needs to be "..\\..\\.." to resolve prefix.
https://bugs.python.org/issue45582