bpo-22047: [argparse] deprecate nested argument groups and mutually e… - #30098
Merged
iritkatriel merged 2 commits intoDec 16, 2021
Merged
bpo-22047: [argparse] deprecate nested argument groups and mutually e…#30098iritkatriel merged 2 commits into
iritkatriel merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
willingc
approved these changes
Dec 16, 2021
willingc
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Thanks @iritkatriel.
Sorry, something went wrong.
Copy link
Copy Markdown
|
What was the rationale behind this? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
The background is in the issue. |
Sorry, something went wrong.
alpernebbi
added a commit
to alpernebbi/depthcharge-tools
that referenced
this pull request
Sep 26, 2022
This makes Groups able to somewhat properly wrap Arguments and other Groups, so that we can add @Group.add on top of an @argument() chain which already creates an implicit group for a single method. Nesting groups is slightly problematic because argparse doesn't really support them [1]. Most important issue for us is that the inner groups don't show up in the help message, but that is easily solved by flattening the arguments into the outermost group. [1] python/cpython#30098 Signed-off-by: Alper Nebi Yasak <alpernebiyasak@gmail.com>
luispadron
pushed a commit
to bazelbuild/rules_apple
that referenced
this pull request
Jan 3, 2024
…2334) Fixes #2310 by removing the mutually exclusive code signing arg group in `imported_dynamic_framework_processor.py`. Per python/cpython#30098 the nested configuration was never intended to work anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…xclusive groups
https://bugs.python.org/issue22047